Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialyzer: Eliminate the race_conditions option #5502

Merged

Conversation

bjorng
Copy link
Contributor

@bjorng bjorng commented Dec 9, 2021

The race_conditions option has not matured despite having been in
Dialyzer since 2008. Quoting its documentation:

Notice that the analysis that finds data races performs
intra-procedural data flow analysis and can sometimes explode in
time. Enable it at your own risk.

Removing the race_conditions option simplifies the Dialyzer code base;
especially the dialyzer_dataflow module.

The `race_conditions` option has not matured despite having been in
Dialyzer since 2008. Quoting its documentation:

> Notice that the analysis that finds data races performs
  intra-procedural data flow analysis and can sometimes explode in
  time. Enable it at your own risk.

Removing the `race_conditions` option simplifies the Dialyzer code base;
especially the `dialyzer_dataflow` module.
@bjorng bjorng added team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI labels Dec 9, 2021
@bjorng bjorng requested a review from jhogberg December 9, 2021 08:18
@bjorng bjorng self-assigned this Dec 9, 2021
@bjorng bjorng merged commit 3d37bd9 into erlang:master Dec 13, 2021
@bjorng bjorng deleted the bjorn/dialyzer/eliminate-races/OTP-17819 branch December 13, 2021 09:21
g-andrade added a commit to g-andrade/aequitas that referenced this pull request Apr 9, 2022
g-andrade added a commit to g-andrade/deigma that referenced this pull request Apr 9, 2022
g-andrade added a commit to g-andrade/erlffx that referenced this pull request Apr 9, 2022
g-andrade added a commit to g-andrade/taskforce that referenced this pull request Apr 9, 2022
g-andrade added a commit to g-andrade/yabko that referenced this pull request Apr 9, 2022
g-andrade added a commit to g-andrade/fake_lager that referenced this pull request Apr 9, 2022
g-andrade added a commit to g-andrade/locus that referenced this pull request Apr 9, 2022
g-andrade added a commit to g-andrade/tls_certificate_check that referenced this pull request Apr 9, 2022
gabrielpedepera added a commit to gabrielpedepera/dialyxir that referenced this pull request Oct 24, 2022
@apoorv-2204
Copy link

why did we have it in the first place?
If there is any race condition how do we determine it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants