Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handled setter builtin heads and supported feature __proto__ for Test262 #127

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Handled setter builtin heads and supported feature __proto__ for Test262 #127

merged 3 commits into from
Dec 14, 2022

Conversation

jhnaldo
Copy link
Contributor

@jhnaldo jhnaldo commented Dec 14, 2022

This PR supported Object.prototype.__proto__ as follows:

$ test262-test -test262-test:log tests/test262/test/language/expressions/class/poisoned-underscore-proto.js
========================================
 extract phase
----------------------------------------
========================================
 compile phase
----------------------------------------
========================================
 build-cfg phase
----------------------------------------
========================================
 test262-test phase
----------------------------------------
[Interpreter] Logging into .../esmeta/logs/test262...
[Interpreter] Logging finished
PASS

@jhnaldo jhnaldo added enhancement Enhance the quality of a feature area:lang Related to metalanguage area:builtin Related to built-in objects labels Dec 14, 2022
@jhnaldo jhnaldo merged commit 61ad8c3 into dev Dec 14, 2022
@jhnaldo jhnaldo deleted the dev-setter-builtin branch December 14, 2022 07:43
doehyunbaek added a commit that referenced this pull request Dec 14, 2022
@doehyunbaek
Add getter and setter to supported features.
71639a6 
After #127, __getter__ and __setter__ works as well.
Tested with `sbt:esmeta> run test262-test -test262-test:log tests/test262/test/built-ins/Object/prototype/`
@doehyunbaek doehyunbaek mentioned this pull request Dec 14, 2022
Merged
jhnaldo pushed a commit that referenced this pull request Dec 14, 2022
@doehyunbaek
Add getter and setter to supported features. (#129)
23d5871 
After #127, __getter__ and __setter__ works as well.
Tested with `sbt:esmeta> run test262-test -test262-test:log tests/test262/test/built-ins/Object/prototype/`
jhnaldo pushed a commit that referenced this pull request May 18, 2023
@doehyunbaek @jhnaldo
Add getter and setter to supported features. (#129)
222c845 
After #127, __getter__ and __setter__ works as well.
Tested with `sbt:esmeta> run test262-test -test262-test:log tests/test262/test/built-ins/Object/prototype/`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:builtin Related to built-in objects area:lang Related to metalanguage enhancement Enhance the quality of a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jhnaldo