Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrap to completion if function returns completion record type #152

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

hyp3rflow
Copy link
Member

The result type modified by Interpreter.setTypeMap needs to be rewrapped if the function returns completion record.
There are already many parts of our code do the same thing.

as.map(v => if (cp.func.isReturnComp) v.wrapCompletion else v)

if (st.context.func.isReturnComp) value.wrapCompletion else value,

... and more.

And this PR adds/moves some comments related with Implicit Normal Completion.

@hyp3rflow hyp3rflow added the area:analyzer Related to analyzer label Jul 3, 2023
@hyp3rflow hyp3rflow requested a review from jhnaldo July 3, 2023 05:32
@hyp3rflow hyp3rflow self-assigned this Jul 3, 2023
Copy link
Contributor

@jhnaldo jhnaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@jhnaldo jhnaldo added bug Something isn't working area:type Related to types labels Jul 3, 2023
@jhnaldo jhnaldo merged commit e3245f5 into dev Jul 17, 2023
@jhnaldo jhnaldo deleted the fix/completion-comments branch July 17, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:analyzer Related to analyzer area:type Related to types bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants