Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in tymodel and manual IR #164

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Fix typo in tymodel and manual IR #164

merged 2 commits into from
Aug 4, 2023

Conversation

hyp3rflow
Copy link
Member

This PR fixes following typos:

  • IntegerIndexedExoticObject fields
  • Function.prototype.toString IR

Type analysis result:

=== Affected by IntegerIndexedExoticObject changes
    def <BUILTIN>:INTRINSICS.get TypedArray.prototype[@@toStringTag](this: ESValue, ArgumentsList: List[ESValue], NewTarget: Object | Undefined): Unknown
--> def <BUILTIN>:INTRINSICS.get TypedArray.prototype[@@toStringTag](this: ESValue, ArgumentsList: List[ESValue], NewTarget: Object | Undefined): Normal[Undefined]
+-> def <BUILTIN>:INTRINSICS.get TypedArray.prototype[@@toStringTag](this: ESValue, ArgumentsList: List[ESValue], NewTarget: Object | Undefined): Normal[String | Undefined]

    def ValidateAtomicAccess(typedArray: Unknown["TypedArray"], requestIndex: Unknown): Unknown["EitherANormalCompletionContainingAnIntegerOrAnAbruptCompletion"]
--> def ValidateAtomicAccess(typedArray: Bot, requestIndex: Bot): Unknown["EitherANormalCompletionContainingAnIntegerOrAnAbruptCompletion"]
+-> def ValidateAtomicAccess(typedArray: ESValue, requestIndex: ESValue): Abrupt[throw]

    def ValidateIntegerTypedArray(typedArray: Unknown, waitable?: Boolean): Unknown["EitherANormalCompletionContainingEitherAnArrayBufferOrASharedArrayBuffer,OrAnAbruptCompletion"]
--> def ValidateIntegerTypedArray(typedArray: ESValue, waitable: Boolean): Abrupt
+-> def ValidateIntegerTypedArray(typedArray: ESValue, waitable: Boolean): Normal[ArrayBufferObject | Absent] | Abrupt

=== Affected by Function.prototype.toString IR change
    def <BUILTIN>:INTRINSICS.Function.prototype.toString(this: ESValue, ArgumentsList: List[ESValue], NewTarget: Object | Undefined): Unknown
--> def <BUILTIN>:INTRINSICS.Function.prototype.toString(this: ESValue, ArgumentsList: List[ESValue], NewTarget: Object | Undefined): Normal[String] | Abrupt[throw]
+-> def <BUILTIN>:INTRINSICS.Function.prototype.toString(this: ESValue, ArgumentsList: List[ESValue], NewTarget: Object | Undefined): Normal[String | Absent] | Abrupt[throw]

@hyp3rflow hyp3rflow requested a review from jhnaldo July 25, 2023 04:22
@hyp3rflow hyp3rflow self-assigned this Jul 25, 2023
@jhnaldo jhnaldo removed their request for review July 26, 2023 06:45
Copy link
Contributor

@jhnaldo jhnaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@jhnaldo jhnaldo merged commit 57fe735 into dev Aug 4, 2023
6 checks passed
@jhnaldo jhnaldo deleted the dev-tymodel-typo branch August 4, 2023 04:13
@jhnaldo jhnaldo added bug Something isn't working area:ir Related to intermediate representation (IR) area:type Related to types labels Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ir Related to intermediate representation (IR) area:type Related to types bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants