Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix propRef of parser to pass test262 #200

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Fix propRef of parser to pass test262 #200

merged 1 commit into from
Jan 17, 2024

Conversation

d01c2
Copy link
Contributor

@d01c2 d01c2 commented Jan 12, 2024

This PR includes:

  • propRef fix of parser to pass test262

During testing with test262, we encountered an issue where the statement "Let _rawValue_ be the String value _rawStrings_[_index_]." was not parsing correctly. To alleviate this problem, we have made modification to propRef to address this issue.

@d01c2 d01c2 changed the base branch from main to dev January 12, 2024 01:53
@d01c2 d01c2 marked this pull request as ready for review January 12, 2024 01:54
@d01c2 d01c2 requested a review from jhnaldo January 12, 2024 02:29
@d01c2
Copy link
Contributor Author

d01c2 commented Jan 16, 2024

With this modification, 44 previously unsupported tests have now passed.

- not-supported (N): 28,523
+ not-supported (N): 28,479

Additionally, the names of the newly passed files are as follows:

"built-ins/String/raw/return-the-string-value-from-template.js",
"built-ins/String/raw/special-characters.js",
"built-ins/String/raw/zero-literal-segments.js",
"built-ins/String/raw/template-substitutions-are-appended-on-same-index.js",
"language/expressions/new.target/value-via-tagged-template.js",
"language/expressions/optional-chaining/call-expression.js",
"language/expressions/tagged-template/cache-differing-expressions-eval.js",
"language/expressions/tagged-template/cache-different-functions-same-site.js",
"language/expressions/tagged-template/cache-differing-raw-strings.js",
"language/expressions/tagged-template/cache-differing-expressions.js",
"language/expressions/tagged-template/cache-differing-expressions-new-function.js",
"language/expressions/tagged-template/cache-differing-string-count.js",
"language/expressions/tagged-template/cache-identical-source-eval.js",
"language/expressions/tagged-template/cache-identical-source.js",
"language/expressions/tagged-template/cache-identical-source-new-function.js",
"language/expressions/tagged-template/cache-eval-inner-function.js",
"language/expressions/tagged-template/cache-same-site-top-level.js",
"language/expressions/tagged-template/cache-same-site.js",
"language/expressions/tagged-template/call-expression-context-strict.js",
"language/expressions/tagged-template/chained-application.js",
"language/expressions/tagged-template/call-expression-argument-list-evaluation.js",
"language/expressions/tagged-template/constructor-invocation.js",
"language/expressions/tagged-template/member-expression-context.js",
"language/expressions/tagged-template/member-expression-argument-list-evaluation.js",
"language/expressions/tagged-template/tco-member.js",
"language/expressions/tagged-template/tco-call.js",
"language/expressions/tagged-template/template-object-frozen-strict.js",
"language/expressions/tagged-template/invalid-escape-sequences.js",
"language/expressions/tagged-template/template-object-template-map.js",
"language/expressions/template-literal/evaluation-order.js",
"language/expressions/tagged-template/template-object.js",
"language/expressions/template-literal/tv-hex-escape-sequence.js",
"language/expressions/template-literal/tv-null-character-escape-sequence.js",
"language/expressions/template-literal/tv-no-substitution.js",
"language/expressions/template-literal/tv-character-escape-sequence.js",
"language/expressions/template-literal/tv-line-terminator-sequence.js",
"language/expressions/template-literal/tv-template-character.js",
"language/expressions/template-literal/tv-line-continuation.js",
"language/expressions/template-literal/tv-template-characters.js",
"language/expressions/template-literal/tv-template-head.js",
"language/expressions/template-literal/tv-template-middle.js",
"language/expressions/template-literal/tv-template-tail.js",
"language/expressions/template-literal/tv-zwnbsp.js",
"language/expressions/template-literal/tv-utf16-escape-sequence.js"

Copy link
Contributor

@jhnaldo jhnaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@jhnaldo jhnaldo merged commit abf11b5 into dev Jan 17, 2024
6 checks passed
@jhnaldo jhnaldo deleted the fix-parser-propRef branch January 17, 2024 02:19
@jhnaldo jhnaldo added area:lang Related to metalanguage area:parser Related to parsers labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:lang Related to metalanguage area:parser Related to parsers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants