[Fix] sync Object.keys excluded list from object-keys

- ljharb/object-keys@f09421a Fixes #456.
es-shims · Aug 31, 2018 · 147c0d8 · 147c0d8
1 parent a265a13
commit 147c0d8
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/es5-shim.js b/es5-shim.js
@@ -1007,16 +1007,28 @@
         return ctor && ctor.prototype === o;
     };
     var excludedKeys = {
-        $window: true,
+        $applicationCache: true,
         $console: true,
-        $parent: true,
-        $self: true,
+        $external: true,
         $frame: true,
-        $frames: true,
         $frameElement: true,
+        $frames: true,
+        $innerHeight: true,
+        $innerWidth: true,
+        $outerHeight: true,
+        $outerWidth: true,
+        $pageXOffset: true,
+        $pageYOffset: true,
+        $parent: true,
+        $scrollLeft: true,
+        $scrollTop: true,
+        $scrollX: true,
+        $scrollY: true,
+        $self: true,
         $webkitIndexedDB: true,
         $webkitStorageInfo: true,
-        $external: true,
+        $window: true,
+
         $width: true,
         $height: true,
         $top: true,

diff --git a/tests/spec/s-object.js b/tests/spec/s-object.js
@@ -140,7 +140,7 @@ describe('Object', function () {
 
         ifWindowIt('can serialize all objects on the `window`', function () {
             var windowItemKeys, exception;
-            var excludedKeys = ['window', 'console', 'parent', 'self', 'frame', 'frames', 'frameElement', 'external', 'height', 'width', 'top', 'localStorage'];
+            var excludedKeys = ['window', 'console', 'parent', 'self', 'frame', 'frames', 'frameElement', 'external', 'height', 'width', 'top', 'localStorage', 'applicationCache'];
             if (supportsDescriptors) {
                 Object.defineProperty(window, 'thrower', {
                     configurable: true,