Skip to content

Commit

Permalink
Get rid of benchmark problem class constructors (facebook#2605)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#2605

Context: Benchmark problems are sometimes created with class methods `SingleObjectiveBenchmarkProblem.from_botorch`, `SingleObjectiveBenchmarkProblem.from_botorch_synthetic`, and `MultiObjectiveBenchmarkProblem.from_botorch_multi_objective`, the former two now being identical. This creates the need for some tricky type annotations; to me, replacing these with functions is obviously cleaner. This will make it easier to consolidate classes in the future.

This PR:
* Replaces `SingleObjectiveBenchmarkProblem.from_botorch` and `SingleObjectiveBenchmarkProblem.from_botorch_synthetic` with `create_single_objective_problem_from_botorch`
* Replaces `MultiObjectiveBenchmarkProblem.from_botorch_multi_objective` with `create_multi_objective_problem_from_botorch`

Differential Revision: D60284484

Reviewed By: saitcakmak
  • Loading branch information
esantorella authored and facebook-github-bot committed Jul 28, 2024
1 parent aa53efd commit 79627e7
Show file tree
Hide file tree
Showing 5 changed files with 216 additions and 239 deletions.
Loading

0 comments on commit 79627e7

Please sign in to comment.