Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created an endpoint selection modal popup for users to save, add improvements on endpoint selection #630

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

downiec
Copy link
Collaborator

@downiec downiec commented Apr 4, 2024

Description

The endpoints that are saved will populate the drop-down endpoint selection so that users can choose the endpoint to transfer to. Created the variables to save the endpoint list in the session storage the same as other Globus download data is saved.

Fixes # (issue)

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Local Pre-commit Checks
  • CI/CD Build

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • If applicable - I have commented my code, particularly in hard-to-understand areas
  • If applicable - I have made corresponding changes to the documentation
  • If applicable - I have added tests that prove my fix is effective or that my feature works
  • If applicable - New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@downiec downiec self-assigned this Apr 4, 2024
…rch popup. This will be addressed more elegantly in the future.
… in a local scope object and keep them loaded/synchronized with session storage when redirects occur. Did a rewrite of the transfer function which uses goals to keep track of what the user wanted to do between redirects. Uses local storage to save goals, as it is faster and more reliable than session storage. Consolidated and simplifed the globus transfer related data types and atoms. Globus transfers seem to be failing when testing locally, and that issue will still need to be addressed. Removed the default endpoint in favor of allowing users to save their endpoints and prefered paths, and that is then saved in session storage for when they would log in later.
…y can be used by other components. Re-organized the globus download steps function so that sign in tokens aren't required when setting the path of a saved endpoint. Also simplified the flow of the function to follow based on user goals rather than page state.
@sashakames sashakames changed the base branch from globus-update-scopes to v1.1.2-rc July 15, 2024 21:16
@sashakames sashakames merged commit ec5ec89 into v1.1.2-rc Jul 15, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants