We probably don't care if the hook was stopped

esl · Jan 12, 2022 · 84b267f · 84b267f
1 parent 3bf8282
commit 84b267f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/gen_hook.erl b/src/gen_hook.erl
@@ -204,7 +204,7 @@ run_hook([Handler | Ls], Acc, Params, Key) ->
         {ok, NewAcc} ->
             run_hook(Ls, NewAcc, Params, Key);
         {stop, NewAcc} ->
-            {stop, NewAcc};
+            {ok, NewAcc};
         Other ->
             ?MODULE:error_running_hook(Other, Handler, Acc, Params, Key),
             run_hook(Ls, Acc, Params, Key)

diff --git a/test/gen_hook_SUITE.erl b/test/gen_hook_SUITE.erl
@@ -249,7 +249,7 @@ run_fold_stops_when_handler_returns_stop(_) ->
     ?assertEqual(ok, gen_hook:add_handlers(HookHandlers)),
     %% run the hook
     N = ((0 + 3) * 2), %% 6
-    ?assertEqual({stop, N}, gen_hook:run_fold(calculate, ?HOOK_TAG1, 0, #{n => 2})),
+    ?assertEqual({ok, N}, gen_hook:run_fold(calculate, ?HOOK_TAG1, 0, #{n => 2})),
     %% check hook handlers execution sequence
     Self = self(),
     ?assertEqual([{Self,