Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the check for already loaded backend modules #1438

Merged
merged 2 commits into from
Nov 6, 2018

Conversation

chrzaszcz
Copy link
Member

Fix the expected backend module name to correctly recognize if the module has already been loaded.

@chrzaszcz chrzaszcz closed this Aug 17, 2017
@chrzaszcz chrzaszcz reopened this Aug 17, 2017
@chrzaszcz chrzaszcz requested review from kzemek and removed request for kzemek August 17, 2017 11:36
@chrzaszcz chrzaszcz closed this Aug 17, 2017
@chrzaszcz chrzaszcz reopened this Aug 17, 2017
@fenek fenek added the WIP 🚧 label Nov 23, 2017
@mongoose-im

This comment has been minimized.

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #1438 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1438      +/-   ##
==========================================
+ Coverage   76.91%   76.99%   +0.07%     
==========================================
  Files         323      323              
  Lines       28116    28226     +110     
==========================================
+ Hits        21626    21732     +106     
- Misses       6490     6494       +4
Impacted Files Coverage Δ
src/backend_module.erl 96.87% <100%> (+3.54%) ⬆️
src/inbox/mod_inbox.erl 94.7% <100%> (ø) ⬆️
src/muc_light/mod_muc_light_utils.erl 83.33% <0%> (-4.06%) ⬇️
src/mam/mod_mam_rdbms_prefs.erl 92.52% <0%> (-3.74%) ⬇️
src/rdbms/mongoose_rdbms.erl 67.21% <0%> (-2.74%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 82.22% <0%> (-2.23%) ⬇️
src/mam/mod_mam_utils.erl 82.37% <0%> (-0.68%) ⬇️
src/mod_muc_log.erl 77.69% <0%> (ø) ⬆️
src/gen_mod.erl 75.53% <0%> (ø) ⬆️
src/auth/ejabberd_auth_external.erl 32.07% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ec67f8...b4c3bb1. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Nov 6, 2018

5817.1 / Erlang 19.3 / small_tests / ccc2356
Reports root / small


5817.5 / Erlang 19.3 / ldap_mnesia / ccc2356
Reports root/ big
OK: 1060 / Failed: 3 / User-skipped: 88 / Auto-skipped: 21

vcard_simple_SUITE:all:retrieve_own_card
{error,{test_case_failed,"Expected <<\"alice\">> got undefined\n"}}

Report log

vcard_simple_SUITE:all:retrieve_own_card
{error,{test_case_failed,"Expected <<\"alice\">> got undefined\n"}}

Report log

vcard_simple_SUITE:all:retrieve_own_card
{error,{test_case_failed,"Expected <<\"alice\">> got undefined\n"}}

Report log


5817.3 / Erlang 19.3 / mysql_redis / ccc2356
Reports root/ big
OK: 2874 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0


5817.2 / Erlang 19.3 / internal_mnesia / ccc2356
Reports root/ big
OK: 1129 / Failed: 2 / User-skipped: 51 / Auto-skipped: 0

mod_global_distrib_SUITE:mod_global_distrib:test_pm_with_ungraceful_reconnection_to_different_server
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"eve82.588239@localhost/res1">>,escalus_tcp,
          <0.12938.1>,
          [{event_manager,<0.12929.1>},
           {server,<<"localhost">>},
           {username,<<"eve82.588239">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.12929.1>},
            {server,<<"localhost">>},
            {username,<<"eve82.588239">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"eve82.588239">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"eve82.588239">>},
           {server,<<"localhost">>},
           {password,<<"password">>},
           {port,5222},
           {stream_management,true},
           {stream_id,<<"775736CC26DB3C0C">>}]},
        10000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {mod_global_distrib_SUITE,
       '-test_pm_with_ungraceful_reconnection_to_different_server/1-fun-0-',
       4,
       [{file,"mod_global_distrib_SUITE.erl"},{line,607}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
    ...

Report log

mod_global_distrib_SUITE:mod_global_distrib:test_pm_with_ungraceful_reconnection_to_different_server
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"eve22.828593@localhost/res1">>,escalus_tcp,
          <0.13560.1>,
          [{event_manager,<0.13551.1>},
           {server,<<"localhost">>},
           {username,<<"eve22.828593">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.13551.1>},
            {server,<<"localhost">>},
            {username,<<"eve22.828593">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"eve22.828593">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"eve22.828593">>},
           {server,<<"localhost">>},
           {password,<<"password">>},
           {port,5222},
           {stream_management,true},
           {stream_id,<<"BCD5E1DAAAC579C6">>}]},
        10000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {mod_global_distrib_SUITE,
       '-test_pm_with_ungraceful_reconnection_to_different_server/1-fun-0-',
       4,
       [{file,"mod_global_distrib_SUITE.erl"},{line,607}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
    ...

Report log


5817.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / ccc2356
Reports root/ big
OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0


5817.4 / Erlang 19.3 / odbc_mssql_mnesia / ccc2356
Reports root/ big
OK: 2888 / Failed: 0 / User-skipped: 208 / Auto-skipped: 0


5817.8 / Erlang 20.0 / pgsql_mnesia / ccc2356
Reports root/ big / small
OK: 2920 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0


5817.9 / Erlang 21.0 / riak_mnesia / ccc2356
Reports root/ big / small
OK: 1326 / Failed: 0 / User-skipped: 49 / Auto-skipped: 0


5817.2 / Erlang 19.3 / internal_mnesia / ccc2356
Reports root/ big
OK: 1103 / Failed: 0 / User-skipped: 51 / Auto-skipped: 0


5817.5 / Erlang 19.3 / ldap_mnesia / ccc2356
Reports root/ big
OK: 1068 / Failed: 0 / User-skipped: 86 / Auto-skipped: 0

@michalwski michalwski merged commit 9712739 into master Nov 6, 2018
@michalwski michalwski deleted the backend-module-fix branch November 6, 2018 13:25
@fenek fenek added this to the 3.1.0++ milestone Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants