Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAM documentation fixes #1456

Merged
merged 4 commits into from
Sep 12, 2017
Merged

MAM documentation fixes #1456

merged 4 commits into from
Sep 12, 2017

Conversation

arkgil
Copy link
Contributor

@arkgil arkgil commented Aug 30, 2017

The main change of this PR is a removal of mnesia_dirty prefs store from documentation and mod_mam_meta module. I've also fixed the link to MAM XEP (it points to 0.6 though) and took a chance to improve rendering of bullet points (4 spaces make a nested bullet point! 👍 )

@fenek
Copy link
Member

fenek commented Sep 5, 2017

There are still some leftovers. :)

MongooseIM $ grep -nr "mnesia_dirty" .
./apps/ejabberd/test/cowboy_SUITE_data/ejabberd.onlyhttp.cfg:650:% {mod_mam_mnesia_dirty_prefs, [pm, muc]},
./apps/ejabberd/test/cowboy_SUITE_data/ejabberd.onlyhttp.cfg:718:% {mod_mam_mnesia_dirty_prefs, [pm]},
./apps/ejabberd/test/cowboy_SUITE_data/ejabberd.onlyws.cfg:650:% {mod_mam_mnesia_dirty_prefs, [pm, muc]},
./apps/ejabberd/test/cowboy_SUITE_data/ejabberd.onlyws.cfg:718:% {mod_mam_mnesia_dirty_prefs, [pm]},
./apps/ejabberd/test/ejabberd_config_SUITE_data/ejabberd.default.cfg:630:% {mod_mam_mnesia_dirty_prefs, [pm, muc]},
./apps/ejabberd/test/ejabberd_config_SUITE_data/ejabberd.default.cfg:693:% {mod_mam_mnesia_dirty_prefs, [pm]},
./apps/ejabberd/test/ejabberd_config_SUITE_data/ejabberd.split.cfg:647:% {mod_mam_mnesia_dirty_prefs, [pm, muc]},
./apps/ejabberd/test/ejabberd_config_SUITE_data/ejabberd.split.cfg:710:% {mod_mam_mnesia_dirty_prefs, [pm]},
./apps/ejabberd/test/ejabberd_config_SUITE_data/ejabberd.with_mod_offline.cfg:631:% {mod_mam_mnesia_dirty_prefs, [pm, muc]},
./apps/ejabberd/test/ejabberd_config_SUITE_data/ejabberd.with_mod_offline.cfg:694:% {mod_mam_mnesia_dirty_prefs, [pm]},
./apps/ejabberd/test/ejabberd_config_SUITE_data/ejabberd.with_mod_offline.different_opts.cfg:631:% {mod_mam_mnesia_dirty_prefs, [pm, muc]},
./apps/ejabberd/test/ejabberd_config_SUITE_data/ejabberd.with_mod_offline.different_opts.cfg:694:% {mod_mam_mnesia_dirty_prefs, [pm]},
./apps/ejabberd/test/revproxy_SUITE_data/ejabberd.norules.cfg:650:% {mod_mam_mnesia_dirty_prefs, [pm, muc]},
./apps/ejabberd/test/revproxy_SUITE_data/ejabberd.norules.cfg:718:% {mod_mam_mnesia_dirty_prefs, [pm]},
./apps/ejabberd/test/revproxy_SUITE_data/ejabberd.onerule.cfg:653:% {mod_mam_mnesia_dirty_prefs, [pm, muc]},
./apps/ejabberd/test/revproxy_SUITE_data/ejabberd.onerule.cfg:721:% {mod_mam_mnesia_dirty_prefs, [pm]},
./doc/user-guide/ICE_tutorial/ejabberd.cfg:837:%   {user_prefs_store, mnesia_dirty},
./doc/user-guide/ICE_tutorial/ejabberd.cfg:880:%     {user_prefs_store, mnesia_dirty}
./rel/files/ejabberd.cfg.token-support:690:% {mod_mam_mnesia_dirty_prefs, [pm, muc]},
./rel/files/ejabberd.cfg.token-support:753:% {mod_mam_mnesia_dirty_prefs, [pm]},

Copy link
Member

@fenek fenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some leftovers still need to be removed.

@arkgil
Copy link
Contributor Author

arkgil commented Sep 5, 2017

Hm, but of all those files only one uses the new MAM config format. What should I do with the other ones? Is the old format valid anymore?

@fenek
Copy link
Member

fenek commented Sep 5, 2017

Old format can still be used. Just remove/update the examples with mnesia_dirty without analysis if all of these files are still used in project.

@arkgil
Copy link
Contributor Author

arkgil commented Sep 7, 2017

@fenek I've deleted the leftovers.

@fenek fenek merged commit f776e75 into master Sep 12, 2017
@fenek fenek deleted the mam-doc-fixes branch September 12, 2017 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants