Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for mod_aws_sns #1492

Merged
merged 2 commits into from
Oct 2, 2017
Merged

Update docs for mod_aws_sns #1492

merged 2 commits into from
Oct 2, 2017

Conversation

kanes115
Copy link
Contributor

One of the config options needs to be changed:
token_muc_messages_topic --> muc_messages_topic
because that's how it's fetched module itself

@kanes115 kanes115 self-assigned this Sep 29, 2017
@kanes115 kanes115 requested a review from fenek September 29, 2017 06:59
@kanes115 kanes115 changed the title mod_aws_sns docs update Update docs for mod_aws_sns Sep 29, 2017
@kanes115 kanes115 added this to the 2.1.0 milestone Sep 29, 2017
Copy link
Member

@fenek fenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that lists are always separated from the text with one empty line. Without it, the formatting breaks in ReadTheDocs: http://mongooseim.readthedocs.io/en/latest/modules/mod_aws_sns/

In case of this doc it is about line 3.

@Nyco
Copy link
Contributor

Nyco commented Sep 29, 2017

+* muc_messages_topic (optional, string, default: unset)

@fenek
Copy link
Member

fenek commented Oct 2, 2017

@Nyco

What is wrong with this line?

@fenek fenek merged commit a701493 into master Oct 2, 2017
@fenek fenek deleted the aws_sns_doc_update branch October 2, 2017 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants