Change passwordlike to passterm #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OTP 20 build is considered not passed but there is not a single test that failed. Why? (ping: @fenek ) |
|
@kanes115 This one failed: https://travis-ci.org/esl/MongooseIM/jobs/295211289 :) |
|
@fenek , I know which job failed - this is inside the job that I don't find any failed tests :( |
|
Ouch. :D Well, it's restarted already. Sometimes the job may fail if Cover exits with a segfault (very rare but does happen). In such case you won't see any failed test cases. |
fenek
approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name
passwordlikesmells. As it can't bepasswordbecause it is either binary (word) OR TUPLE of type scram:scram_tuple() we will call itpassTERM.It plays a role of passWORD but instead of being a WORD it is a WORD or TUPLE. The smallest denominator then is TERM. This way we also let somebody extend it for any type of pass phrase he/she needs.