muc_SUITE kicked_after_sending_malformed_presence test

[SauronSauron]

muc_SUITE kicked_after_sending_malformed_presence does not terminate room until test is done.

This PR addresses redmine 17047

17047 Description

I'm disabling this test case on master to reduce the pain with Travis builds. It has to be verified and fixed.

====== Suite FAILED: muc_SUITE (1 of 119 tests failed)
====== Test name: kicked_after_sending_malformed_presence
====== Reason:    {timeout_when_waiting_for_stanza,
                      [{escalus_client,wait_for_stanza,
                           [{client,<<"kate87.108954@localhost/res1">>,
                                escalus_tcp,#Port<0.40135>,false,false,
                                <0.20540.0>,
                                [{event_manager,<0.20285.0>},
                                 {server,<<"localhost">>},
                                 {username,<<"kate87.108954">>},
                                 {resource,<<"res1">>}]},
                            1000],
                           [{file,"src/escalus_client.erl"},{line,121}]},
                       {muc_SUITE,
                           '-kicked_after_sending_malformed_presence/1-fun-0-',
                           3,
                           [{file,"muc_SUITE.erl"},{line,2721}]},
                       {escalus_story,story,3,
                           [{file,"src/escalus_story.erl"},{line,40}]},
                       {muc_SUITE,kicked_after_sending_malformed_presence,1,
                           [{file,"muc_SUITE.erl"},{line,2698}]},
                       {test_server,ts_tc,3,
                           [{file,"test_server.erl"},{line,1533}]},
                       {test_server,run_test_case_eval1,6,
                           [{file,"test_server.erl"},{line,1053}]},
                       {test_server,run_test_case_eval,9,
                           [{file,"test_server.erl"},{line,985}]}]}

[SauronSauron]

I copied the module from another branch and now it seems as if I changed the whole module.
The changes I have done is between line 2792 - 2823. You want me to delete this PR and redo it?

[fenek]

Please simply force push to this branch, no need to create new PR.
Next time I'd recommend using git checkout branch -- file to "copy" the file, not copy & paste. When you take a closer look - you've created ~4000 indent changes.

[arcusfelis]

Assignment inside function calls is not allowed by code standards (?).

[arcusfelis]

Why do we need Kate in the test?

[fenek]

To prevent room process from terminating when Bob is kicked

[arcusfelis]

hmm, maybe the whole test should be something like:

kicked_after_sending_malformed_presence(Config) ->
      muc_helper:with_fresh_room(Config, [{alice, 1}], fun(RoomName, Alice) ->
             muc_helper:join(RoomName, Alice),
             muc_helper:send_malformed_presence(RoomName, Alice),
             muc_helper:gets_kicked(RoomName, Alice),
             muc_helper:assert_not_in_the_room(RoomName, Alice)
             end).

:)
(this comment should be ignored for this PR).

[arcusfelis]

Can we keep both a comment before the testcase and these small comments for each operation?

[arcusfelis]

indention ><

[arcusfelis]

Merge, but squish, replace comments.
Add info about why and how it got fixed into merge comment.