-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all path related functions into path_helper in big tests #1760
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1760 +/- ##
==========================================
+ Coverage 74.6% 74.62% +0.01%
==========================================
Files 283 283
Lines 26578 26578
==========================================
+ Hits 19829 19834 +5
+ Misses 6749 6744 -5
Continue to review full report at Codecov.
|
@@ -20,6 +21,8 @@ endif | |||
|
|||
COMMON_OPTS := -sname test -setcookie ejabberd -hidden \ | |||
$(TLS_DIST_OPTS) \ | |||
-env REPO_DIR "$(shell readlink -f $(REPO_DIR))" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a readlink.sh
file stating that it's needed for MacOS - how does this change work on Mac?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely, was thinking about this
function readlink() {
DIR=$(echo "${1%/*}")
(cd "$DIR" && echo "$(pwd -P)")
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know which is better: readlink.sh
that we have in the repo or your proposed function, but I bet you can work it out :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script looks broken. I will add another one into tools.
./readlink.sh ../
/home/user/erlang/esl/2017/MongooseIM/..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
39d8095
to
a548953
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is continuation of #1626
Proposed changes include: