Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all path related functions into path_helper in big tests #1760

Merged
merged 5 commits into from
Mar 12, 2018

Conversation

arcusfelis
Copy link
Contributor

This PR is continuation of #1626

Proposed changes include:

  • new helper module path_helper
  • new env variables REPO_DIR and TEST_DIR passed to VM, running the big tests

@codecov-io
Copy link

Codecov Report

Merging #1760 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1760      +/-   ##
==========================================
+ Coverage    74.6%   74.62%   +0.01%     
==========================================
  Files         283      283              
  Lines       26578    26578              
==========================================
+ Hits        19829    19834       +5     
+ Misses       6749     6744       -5
Impacted Files Coverage Δ
src/mod_bosh.erl 93.27% <0%> (-1.69%) ⬇️
src/ejabberd_c2s.erl 84.86% <0%> (+0.15%) ⬆️
src/mod_roster.erl 79.16% <0%> (+0.24%) ⬆️
src/mod_mam_muc_odbc_async_pool_writer.erl 73.98% <0%> (+3.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be65c4...e58d211. Read the comment docs.

@arcusfelis arcusfelis requested a review from fenek March 7, 2018 12:07
@@ -20,6 +21,8 @@ endif

COMMON_OPTS := -sname test -setcookie ejabberd -hidden \
$(TLS_DIST_OPTS) \
-env REPO_DIR "$(shell readlink -f $(REPO_DIR))" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, was thinking about this

function readlink() {
  DIR=$(echo "${1%/*}")
  (cd "$DIR" && echo "$(pwd -P)")
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know which is better: readlink.sh that we have in the repo or your proposed function, but I bet you can work it out :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script looks broken. I will add another one into tools.

./readlink.sh ../                                                          
/home/user/erlang/esl/2017/MongooseIM/.. 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@fenek fenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so_good

@fenek fenek added WIP 🚧 and removed ready labels Mar 9, 2018
@arcusfelis arcusfelis merged commit f30aad2 into master Mar 12, 2018
@arcusfelis arcusfelis deleted the no-relative-paths-step2 branch March 12, 2018 10:07
@fenek fenek added this to the 3.0.0 milestone Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants