Add missing GD small suite #1770
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1770 +/- ##
==========================================
+ Coverage 69.61% 74.38% +4.76%
==========================================
Files 289 289
Lines 26860 26860
==========================================
+ Hits 18698 19979 +1281
+ Misses 8162 6881 -1281
Continue to review full report at Codecov.
|
| @@ -0,0 +1,175 @@ | |||
| %%============================================================================== | |||
| %% Copyright 2014 Erlang Solutions Ltd. | |||
There was a problem hiding this comment.
Hahaha :D Copy & paste issues. :D Thanks.
| %%-------------------------------------------------------------------- | ||
|
|
||
|
|
||
| %% missing_struct_ tests verify the behaviour of packet_to_component handler, |
| %% Suite configuration | ||
| %%-------------------------------------------------------------------- | ||
|
|
||
| all() -> |
There was a problem hiding this comment.
we can list cases in all() directly.
I don't see any point of having groups for small suites.
(the only point is that we use groups everywhere).
| From = jid:make(<<"">>, <<"from_service.", (global_host())/binary>>, <<"">>), | ||
| {Acc, To} = fake_acc_to_component(From), | ||
| % The handler must not crash and return unchanged Acc | ||
| Acc = mod_global_distrib_mapping:packet_to_component(Acc, From, To). |
There was a problem hiding this comment.
I am usually using ?assert_equal.
Recently started to use
?assert_equal_extra(A, B, #{comment => "Do you have something to say?", some_var => X, some_other_var => Y})
which contains enough info to figure out what is wrong, without reading logs or suite code in 50% of cases.
I forgot to add this suite to PR #1763 :(