Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MongoosePush's logs on 4xx errors #1777

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Conversation

rslota
Copy link
Contributor

@rslota rslota commented Mar 20, 2018

This PR makes it easier to debug errors with MongoosePush / MongooseIM API incompatibility.

@codecov-io
Copy link

Codecov Report

Merging #1777 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1777      +/-   ##
==========================================
- Coverage   74.47%   74.46%   -0.02%     
==========================================
  Files         290      290              
  Lines       26931    26932       +1     
==========================================
- Hits        20058    20054       -4     
- Misses       6873     6878       +5
Impacted Files Coverage Δ
src/mod_push_service_mongoosepush.erl 88.57% <50%> (-5.55%) ⬇️
...rc/global_distrib/mod_global_distrib_transport.erl 47.05% <0%> (-5.89%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 84.44% <0%> (-2.23%) ⬇️
src/global_distrib/mod_global_distrib_utils.erl 78.57% <0%> (-1.03%) ⬇️
src/ejabberd_sm.erl 82.87% <0%> (-0.69%) ⬇️
src/mod_muc.erl 72.62% <0%> (-0.28%) ⬇️
src/mod_muc_log.erl 77.94% <0%> (-0.26%) ⬇️
src/mod_roster.erl 78.92% <0%> (-0.25%) ⬇️
src/rdbms/mongoose_rdbms.erl 71.22% <0%> (ø) ⬆️
src/mod_mam_utils.erl 88.09% <0%> (+0.68%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43ebd25...d25a875. Read the comment docs.

@fenek fenek merged commit 191bad7 into master Apr 3, 2018
@fenek fenek deleted the handle_mongoosepush_errors branch April 3, 2018 14:54
@fenek fenek added this to the 3.0.0 milestone Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants