Mongoose service+ #1794
Merged
Mongoose service+ #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## mongoose-service #1794 +/- ##
====================================================
+ Coverage 74.16% 74.39% +0.22%
====================================================
Files 291 291
Lines 26999 27002 +3
====================================================
+ Hits 20024 20088 +64
+ Misses 6975 6914 -61
Continue to review full report at Codecov.
|
fenek
force-pushed
the
mongoose-service-alt
branch
from
4d53d02
to
5d582eb
Compare
bartekgorny
added a commit
that referenced
this pull request
Apr 12, 2018
* single callback for module dependencies and requirements * unified vocabulary (no requirements, only deps) * fail module start if required services not loaded (a.k.a. no lazy service startup) * Extend error on circular services dependency
bartekgorny
added a commit
that referenced
this pull request
Apr 16, 2018
* single callback for module dependencies and requirements * unified vocabulary (no requirements, only deps) * fail module start if required services not loaded (a.k.a. no lazy service startup) * Extend error on circular services dependency
|
No docs, oh no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT:
This PR improves #1792 with stuff discussed during tech meeting.
Old description:
This is an alternative to PR#1792, see
https://redmine.erlang-solutions.com/issues/18914
and
https://redmine.erlang-solutions.com/projects/mongooseim/wiki/MongooseIM_global_modules_tech_discussion