Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove esip from default build #1814

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Remove esip from default build #1814

merged 2 commits into from
Apr 17, 2018

Conversation

fenek
Copy link
Member

@fenek fenek commented Apr 17, 2018

  • Remove esip from default build, as it is incompatible with 20.0 and newer
  • Update Jingle/SIP docs with information about proper build and OTP compatibility

@fenek fenek added the WIP 🚧 label Apr 17, 2018
@fenek fenek added this to the 2.2.0 milestone Apr 17, 2018
@codecov
Copy link

codecov bot commented Apr 17, 2018

Codecov Report

Merging #1814 into master will increase coverage by 7.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1814      +/-   ##
==========================================
+ Coverage   67.36%   74.69%   +7.32%     
==========================================
  Files         297      297              
  Lines       27746    27759      +13     
==========================================
+ Hits        18692    20735    +2043     
+ Misses       9054     7024    -2030
Impacted Files Coverage Δ
src/mongoose_fips.erl 41.17% <0%> (-33.83%) ⬇️
src/mod_pubsub.erl 66.01% <0%> (+0.06%) ⬆️
src/mod_roster.erl 79.16% <0%> (+0.24%) ⬆️
src/mod_mam.erl 89.43% <0%> (+0.37%) ⬆️
src/mod_mam_odbc_arch.erl 89.34% <0%> (+0.4%) ⬆️
...c/global_distrib/mod_global_distrib_server_mgr.erl 80.28% <0%> (+0.7%) ⬆️
src/ejabberd_auth_odbc.erl 50.9% <0%> (+0.9%) ⬆️
src/mod_bosh_socket.erl 81.66% <0%> (+1%) ⬆️
src/mod_muc_light_utils.erl 85.26% <0%> (+1.05%) ⬆️
src/mod_muc_light_db_odbc.erl 86.27% <0%> (+1.3%) ⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a41694...294a705. Read the comment docs.

@kzemek kzemek merged commit bdff1eb into master Apr 17, 2018
@kzemek kzemek deleted the remove-sip-from-default branch April 17, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants