Add an option for disabling Riak SSL configuration in setup_riak script #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setup_riak script is used by Tide in order to provision Riak but we do not want to use SSL for connection to the DB. Introduced changes allows to disable the configuration while it's still enabled by default for testing purposes.
michalwski
approved these changes
Apr 24, 2018
|
@michalwski thanks a lot for the review. Can you merge the PR please? I know that one test case fails but it seems that this also happens for other PRs (example). |
|
Yes, there is an issue with mysql container on travis. Is it blocking you @mkacper ? |
|
@michalwski We're going to schedule load tests for OpenSource Mongoose today/tomorrow and this PR is crucial for a load test with Riak backend. |
|
@fenek are you OK with merging any PR before the issue with mysql container is solved? |
|
Ok, the issue with mysql was fixed in master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses adding an option for disabling Riak SSL configuration in setup_riak script.
The script is used by Tide in order to provision Riak but we do not want to use SSL for connection to the DB. Introduced changes allows to disable the configuration while it's still enabled by default for testing purposes.
Proposed changes include: