Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel pull for docker-compose #1883

Merged
merged 2 commits into from
May 24, 2018
Merged

Parallel pull for docker-compose #1883

merged 2 commits into from
May 24, 2018

Conversation

arcusfelis
Copy link
Contributor

This PR addresses "Travis is slow!".

Proposed changes include:

  • use docker pull --parallel
  • use "docker-compose tries to resolve an ip, so slow" - not sure, if we actually need it.

@michalwski
Copy link
Contributor

This is quite good idea, on the other hand after quick comparison with old jobs, this change doesn't save much time (around 10-20s). It still may be useful when we have more containers in tests.

@arcusfelis
Copy link
Contributor Author

true, also sometimes the docker pull can take 3-11 minutes for some reason (travis is slooow?).
In this case parallel pull can be useful.

@fenek fenek added this to the 3.0.0++ milestone May 24, 2018
@fenek fenek merged commit 3e2c8fe into master May 24, 2018
@fenek fenek deleted the parallel-compose branch May 24, 2018 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants