Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce waiting time for cover on CI #1893

Merged
merged 1 commit into from
May 29, 2018
Merged

Reduce waiting time for cover on CI #1893

merged 1 commit into from
May 29, 2018

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented May 29, 2018

This PR addresses "Slow Travis? Slow cover."

Proposed changes include:

  • Add KEEP_COVER_RUNNING variable

"Executing Export cover data from MongooseIM nodes" step works 10 times faster now.

Add KEEP_COVER_RUNNING variable
@arcusfelis arcusfelis merged commit 1bc8515 into master May 29, 2018
@codecov
Copy link

codecov bot commented May 29, 2018

Codecov Report

Merging #1893 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1893      +/-   ##
==========================================
+ Coverage   74.61%   74.62%   +0.01%     
==========================================
  Files         307      307              
  Lines       28134    28135       +1     
==========================================
+ Hits        20991    20996       +5     
+ Misses       7143     7139       -4
Impacted Files Coverage Δ
src/mongoose_cover_helper.erl 8.69% <0%> (-0.4%) ⬇️
src/mod_mam_muc_odbc_async_pool_writer.erl 69.1% <0%> (-4.07%) ⬇️
src/mod_bosh.erl 93.27% <0%> (-1.69%) ⬇️
src/rdbms/mongoose_rdbms.erl 67.83% <0%> (-1.51%) ⬇️
src/mod_bosh_socket.erl 80.66% <0%> (-1%) ⬇️
src/mod_mam_odbc_prefs.erl 95.09% <0%> (-0.99%) ⬇️
src/mod_mam_utils.erl 82.37% <0%> (-0.68%) ⬇️
src/mod_mam.erl 90.27% <0%> (-0.47%) ⬇️
src/mod_muc_log.erl 77.69% <0%> (-0.26%) ⬇️
src/ejabberd_sm.erl 83.72% <0%> (+0.67%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7876629...c3b8a75. Read the comment docs.

@fenek fenek added this to the 3.0.0++ milestone Jun 6, 2018
@fenek fenek deleted the keep-cover-running branch August 23, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants