Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize LDAP #1899

Merged
merged 5 commits into from
Jun 5, 2018
Merged

Dockerize LDAP #1899

merged 5 commits into from
Jun 5, 2018

Conversation

arcusfelis
Copy link
Contributor

This PR addresses "Travis scripts are too travis specific".

Proposed changes include:

  • LDAP running in docker container
  • Make docker-volume logic generic

@codecov
Copy link

codecov bot commented Jun 4, 2018

Codecov Report

Merging #1899 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1899      +/-   ##
==========================================
- Coverage   74.59%   74.57%   -0.02%     
==========================================
  Files         307      307              
  Lines       28135    28135              
==========================================
- Hits        20988    20983       -5     
- Misses       7147     7152       +5
Impacted Files Coverage Δ
...rc/global_distrib/mod_global_distrib_transport.erl 47.05% <0%> (-5.89%) ⬇️
src/mod_push_service_mongoosepush.erl 82.85% <0%> (-5.72%) ⬇️
src/mod_muc_log.erl 77.69% <0%> (-0.77%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 82.39% <0%> (-0.71%) ⬇️
src/eldap_utils.erl 53.95% <0%> (+0.71%) ⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 84.78% <0%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bc8515...281106f. Read the comment docs.

Copy link
Contributor

@ludwikbukowski ludwikbukowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve (working on my OS X machine locally)

@ludwikbukowski ludwikbukowski merged commit fc9f23b into master Jun 5, 2018
@fenek fenek added this to the 3.0.0++ milestone Jun 6, 2018
@fenek fenek deleted the ldap-in-docker branch August 23, 2018 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants