Pass local_host option when accepting session
#1958
Conversation
There was a problem hiding this comment.
Thanks for the change. As for testing if I understand and remember correctly, this reply results in a 200 OK SIP message sent from Mongoose to the Proxy. If so then there are callbacks for it already. It's all in big_tests/tests/jingle_sip_translator.erl, most probably it will be in_invite_transaction_callback/4, other place would be back_invite_callbacks.
src/jingle_sip/mod_jingle_sip.erl
Outdated
| %case nksip_request:reply({ok, [{body, SDP}]}, ReqID) of | ||
| case nksip_request_reply({ok, [{body, SDP}]}, ReqID) of | ||
| LocalHost = gen_mod:get_module_opt(Server, ?MODULE, local_host, "localhost"), | ||
| %case nksip_request:reply({ok, [{body, SDP}, {local_host, LocalHost}]}, ReqID) of |
There was a problem hiding this comment.
I think the commented line can be removed.
|
@michalwski Now that I think about it, asserting Record-Route header in tests won't do any good - it was set to "localhost" anyway, because nksip defaults to address of proxy. |
Lack of this option made nksip generate wrong Record-Route header.
arkgil
force-pushed
the
sip-reply-local-host
branch
from
787a8a4
to
09f72a8
Compare
|
5033.1 / Erlang 19.3 / small_tests / 49c5524 5033.2 / Erlang 19.3 / internal_mnesia / 49c5524 5033.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 49c5524 5033.3 / Erlang 19.3 / mysql_redis / 49c5524 5033.5 / Erlang 19.3 / ldap_mnesia / 49c5524 5033.4 / Erlang 19.3 / odbc_mssql_mnesia / 49c5524 5033.8 / Erlang 20.0 / pgsql_mnesia / 49c5524 5033.9 / Erlang 21.0 / riak_mnesia / 49c5524 |
Codecov Report
@@ Coverage Diff @@
## master #1958 +/- ##
==========================================
+ Coverage 74.75% 74.81% +0.05%
==========================================
Files 309 309
Lines 28047 28048 +1
==========================================
+ Hits 20966 20983 +17
+ Misses 7081 7065 -16
Continue to review full report at Codecov.
|
Lack of this option made nksip generate wrong Record-Route header.
@michalwski Do you have an idea how to test such change? Does
esipallow to provide some kind of callbacks which would be called when SIP stanzas reach its endpoint?