Timestamp support in mod_inbox #1970

fenek · 2018-07-09T17:20:00Z

This PR adds timestamps support to mod_inbox, including sorting and filtering by them.

Also includes a significant refactor of Inbox tests.

mongoose-im · 2018-07-09T17:34:20Z

5089.1 / Erlang 19.3 / small_tests / 013875e
Reports root / small

5089.5 / Erlang 19.3 / ldap_mnesia / 013875e
Reports root/ big
OK: 1028 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0

5089.3 / Erlang 19.3 / mysql_redis / 013875e
Reports root/ big
OK: 2803 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0

5089.2 / Erlang 19.3 / internal_mnesia / 013875e
Reports root/ big
OK: 1064 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0

5089.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 013875e
Reports root/ big
OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0

5089.9 / Erlang 21.0 / riak_mnesia / 013875e
Reports root/ big / small
OK: 1283 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0

5089.8 / Erlang 20.0 / pgsql_mnesia / 013875e
Reports root/ big / small
OK: 2849 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0

codecov · 2018-07-09T21:13:23Z

Codecov Report

Merging #1970 into master will decrease coverage by 0.04%.
The diff coverage is 83.52%.

@@            Coverage Diff            @@
##           master   #1970      +/-   ##
=========================================
- Coverage   75.05%     75%   -0.05%     
=========================================
  Files         314     314              
  Lines       28512   28571      +59     
=========================================
+ Hits        21401   21431      +30     
- Misses       7111    7140      +29

Impacted Files	Coverage Δ
src/inbox/mod_inbox_odbc_pgsql.erl	`100% <ø> (ø)`	⬆️
src/inbox/mod_inbox_odbc_mysql.erl	`100% <ø> (ø)`	⬆️
src/inbox/mod_inbox_odbc_mssql.erl	`100% <100%> (ø)`	⬆️
src/inbox/mod_inbox_odbc.erl	`91.17% <100%> (+2.08%)`	⬆️
src/jlib.erl	`83.27% <100%> (+0.24%)`	⬆️
src/inbox/mod_inbox_utils.erl	`90.69% <100%> (+0.45%)`	⬆️
src/inbox/mod_inbox_muclight.erl	`98.11% <66.66%> (ø)`	⬆️
src/inbox/mod_inbox.erl	`86.04% <73.46%> (-6.18%)`	⬇️
src/pubsub/nodetree_tree.erl	`17.74% <0%> (-30.65%)`	⬇️
src/mam/mod_mam_odbc_prefs.erl	`92.52% <0%> (-3.74%)`	⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b66578...f96e4ef. Read the comment docs.

mongoose-im · 2018-07-09T21:24:26Z

5090.1 / Erlang 19.3 / small_tests / 349ec70
Reports root / small

5090.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 349ec70
Reports root/ big
OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0

5090.5 / Erlang 19.3 / ldap_mnesia / 349ec70
Reports root/ big
OK: 1028 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0

5090.3 / Erlang 19.3 / mysql_redis / 349ec70
Reports root/ big
OK: 2804 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0

5090.2 / Erlang 19.3 / internal_mnesia / 349ec70
Reports root/ big
OK: 1064 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0

5090.8 / Erlang 20.0 / pgsql_mnesia / 349ec70
Reports root/ big / small
OK: 2833 / Failed: 9 / User-skipped: 176 / Auto-skipped: 48

inbox_SUITE:one_to_one:msg_sent_stored_in_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.23579.0>,
          [{event_manager,<0.23578.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.23578.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"DDC33D68D6925BAF">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-msg_sent_stored_in_inbox/1-fun-2-',2,
       [{file,"inbox_SUITE.erl"},{line,264}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_serv...

Report log

inbox_SUITE:one_to_one:msg_sent_stored_in_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.23644.0>,
          [{event_manager,<0.23643.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.23643.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"92E6D6989B6A4B47">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-msg_sent_stored_in_inbox/1-fun-2-',2,
       [{file,"inbox_SUITE.erl"},{line,264}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_serv...

Report log

inbox_SUITE:one_to_one:msg_sent_stored_in_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.23707.0>,
          [{event_manager,<0.23706.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.23706.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"7FA2CAE66093EDEF">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-msg_sent_stored_in_inbox/1-fun-2-',2,
       [{file,"inbox_SUITE.erl"},{line,264}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_serv...

Report log

inbox_SUITE:muclight:simple_groupchat_stored_in_all_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.23748.0>,
          [{event_manager,<0.23747.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.23747.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"BDDDA238C3F4BCB0">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-simple_groupchat_stored_in_all_inbox/1-fun-3-',3,
       [{file,"inbox_SUITE.erl"},{line,438}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{fil...

Report log

inbox_SUITE:muclight:simple_groupchat_stored_in_all_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.23791.0>,
          [{event_manager,<0.23790.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.23790.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"2AC10817E428F709">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-simple_groupchat_stored_in_all_inbox/1-fun-3-',3,
       [{file,"inbox_SUITE.erl"},{line,438}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{fil...

Report log

inbox_SUITE:muclight:simple_groupchat_stored_in_all_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.23834.0>,
          [{event_manager,<0.23833.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.23833.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"B21D9261F595D46">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-simple_groupchat_stored_in_all_inbox/1-fun-3-',3,
       [{file,"inbox_SUITE.erl"},{line,438}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file...

Report log

inbox_SUITE:timestamps:timestamp_is_updated_on_new_message

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.23871.0>,
          [{event_manager,<0.23870.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.23870.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"AFD193331C7B4174">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,'-timestamp_is_updated_on_new_message/1-fun-0-',2,
       [{file,"inbox_SUITE.erl"},{line,785}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1529}]},
     {test_server,run_test_case_eval1...

Report log

inbox_SUITE:timestamps:timestamp_is_updated_on_new_message

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.23906.0>,
          [{event_manager,<0.23905.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.23905.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"2A537A7F439273F1">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,'-timestamp_is_updated_on_new_message/1-fun-0-',2,
       [{file,"inbox_SUITE.erl"},{line,785}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1529}]},
     {test_server,run_test_case_eval1...

Report log

inbox_SUITE:timestamps:timestamp_is_updated_on_new_message

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.23941.0>,
          [{event_manager,<0.23940.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.23940.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"10AC205BF68D4D03">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,'-timestamp_is_updated_on_new_message/1-fun-0-',2,
       [{file,"inbox_SUITE.erl"},{line,785}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1529}]},
     {test_server,run_test_case_eval1...

Report log

5090.9 / Erlang 21.0 / riak_mnesia / 349ec70
Reports root/ big / small
OK: 1283 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0

mongoose-im · 2018-07-10T09:13:23Z

5093.1 / Erlang 19.3 / small_tests / b5878a4
Reports root / small

5093.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / b5878a4
Reports root/ big
OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0

5093.5 / Erlang 19.3 / ldap_mnesia / b5878a4
Reports root/ big
OK: 1028 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0

5093.2 / Erlang 19.3 / internal_mnesia / b5878a4
Reports root/ big
OK: 1064 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0

5093.8 / Erlang 20.0 / pgsql_mnesia / b5878a4
Reports root/ big / small
OK: 2850 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0

5093.3 / Erlang 19.3 / mysql_redis / b5878a4
Reports root/ big
OK: 2804 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0

5093.9 / Erlang 21.0 / riak_mnesia / b5878a4
Reports root/ big / small
OK: 1283 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0

mongoose-im · 2018-07-12T22:19:16Z

5137.1 / Erlang 19.3 / odbc_mssql_mnesia / a5cbb7a
Reports root/ big
OK: 4 / Failed: 9 / User-skipped: 0 / Auto-skipped: 48

inbox_SUITE:one_to_one:msg_sent_stored_in_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.838.0>,
          [{event_manager,<0.837.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.837.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"AC5173F545852512">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-msg_sent_stored_in_inbox/1-fun-2-',2,
       [{file,"inbox_SUITE.erl"},{line,264}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl...

Report log

inbox_SUITE:one_to_one:msg_sent_stored_in_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.941.0>,
          [{event_manager,<0.940.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.940.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"4A665972AA3BDA04">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-msg_sent_stored_in_inbox/1-fun-2-',2,
       [{file,"inbox_SUITE.erl"},{line,264}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl...

Report log

inbox_SUITE:one_to_one:msg_sent_stored_in_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.1042.0>,
          [{event_manager,<0.1041.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.1041.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"B13D462AD217041B">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-msg_sent_stored_in_inbox/1-fun-2-',2,
       [{file,"inbox_SUITE.erl"},{line,264}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server....

Report log

inbox_SUITE:muclight:simple_groupchat_stored_in_all_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.1125.0>,
          [{event_manager,<0.1124.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.1124.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"EFA13F48FE7A0316">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-simple_groupchat_stored_in_all_inbox/1-fun-3-',3,
       [{file,"inbox_SUITE.erl"},{line,438}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"...

Report log

inbox_SUITE:muclight:simple_groupchat_stored_in_all_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.1226.0>,
          [{event_manager,<0.1225.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.1225.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"102D53A96F06C6D2">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-simple_groupchat_stored_in_all_inbox/1-fun-3-',3,
       [{file,"inbox_SUITE.erl"},{line,438}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"...

Report log

inbox_SUITE:muclight:simple_groupchat_stored_in_all_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.1331.0>,
          [{event_manager,<0.1330.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.1330.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"F0FD430CC13734C7">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-simple_groupchat_stored_in_all_inbox/1-fun-3-',3,
       [{file,"inbox_SUITE.erl"},{line,438}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"...

Report log

inbox_SUITE:timestamps:timestamp_is_updated_on_new_message

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.1426.0>,
          [{event_manager,<0.1425.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.1425.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"3BAB67DA0DD684F0">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,'-timestamp_is_updated_on_new_message/1-fun-0-',2,
       [{file,"inbox_SUITE.erl"},{line,785}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1529}]},
     {test_server,run_test_case_eval1,6,...

Report log

inbox_SUITE:timestamps:timestamp_is_updated_on_new_message

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.1499.0>,
          [{event_manager,<0.1498.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.1498.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"2EE085FDD8F751EF">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,'-timestamp_is_updated_on_new_message/1-fun-0-',2,
       [{file,"inbox_SUITE.erl"},{line,785}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1529}]},
     {test_server,run_test_case_eval1,6,...

Report log

inbox_SUITE:timestamps:timestamp_is_updated_on_new_message

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.1576.0>,
          [{event_manager,<0.1575.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.1575.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"2FF101D9C2111016">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,'-timestamp_is_updated_on_new_message/1-fun-0-',2,
       [{file,"inbox_SUITE.erl"},{line,785}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1529}]},
     {test_server,run_test_case_eval1,6,...

Report log

mongoose-im · 2018-07-12T22:47:21Z

5138.1 / Erlang 19.3 / odbc_mssql_mnesia / 4acdce2
Reports root/ big
OK: 4 / Failed: 9 / User-skipped: 0 / Auto-skipped: 48

inbox_SUITE:one_to_one:msg_sent_stored_in_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.838.0>,
          [{event_manager,<0.837.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.837.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"BBD20FC4BF9C6979">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-msg_sent_stored_in_inbox/1-fun-2-',2,
       [{file,"inbox_SUITE.erl"},{line,264}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl...

Report log

inbox_SUITE:one_to_one:msg_sent_stored_in_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.909.0>,
          [{event_manager,<0.908.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.908.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"6C9260C838F93378">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-msg_sent_stored_in_inbox/1-fun-2-',2,
       [{file,"inbox_SUITE.erl"},{line,264}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl...

Report log

inbox_SUITE:one_to_one:msg_sent_stored_in_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.978.0>,
          [{event_manager,<0.977.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.977.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"3099207FC929E2A8">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-msg_sent_stored_in_inbox/1-fun-2-',2,
       [{file,"inbox_SUITE.erl"},{line,264}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl...

Report log

inbox_SUITE:muclight:simple_groupchat_stored_in_all_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.1025.0>,
          [{event_manager,<0.1024.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.1024.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"DE509EDDDE2E1B94">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-simple_groupchat_stored_in_all_inbox/1-fun-3-',3,
       [{file,"inbox_SUITE.erl"},{line,438}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"...

Report log

inbox_SUITE:muclight:simple_groupchat_stored_in_all_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.1078.0>,
          [{event_manager,<0.1077.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.1077.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"AC9AA4C3340E0B5D">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-simple_groupchat_stored_in_all_inbox/1-fun-3-',3,
       [{file,"inbox_SUITE.erl"},{line,438}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"...

Report log

inbox_SUITE:muclight:simple_groupchat_stored_in_all_inbox

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.1131.0>,
          [{event_manager,<0.1130.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.1130.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"970B1BE8EB4205F1">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,check_inbox,3,[{file,"inbox_SUITE.erl"},{line,939}]},
     {inbox_SUITE,'-simple_groupchat_stored_in_all_inbox/1-fun-3-',3,
       [{file,"inbox_SUITE.erl"},{line,438}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"...

Report log

inbox_SUITE:timestamps:timestamp_is_updated_on_new_message

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.1178.0>,
          [{event_manager,<0.1177.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.1177.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"5178910EBE60DED3">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,'-timestamp_is_updated_on_new_message/1-fun-0-',2,
       [{file,"inbox_SUITE.erl"},{line,785}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1529}]},
     {test_server,run_test_case_eval1,6,...

Report log

inbox_SUITE:timestamps:timestamp_is_updated_on_new_message

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.1219.0>,
          [{event_manager,<0.1218.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.1218.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"6D3E8DC748A4C3BD">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,'-timestamp_is_updated_on_new_message/1-fun-0-',2,
       [{file,"inbox_SUITE.erl"},{line,785}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1529}]},
     {test_server,run_test_case_eval1,6,...

Report log

inbox_SUITE:timestamps:timestamp_is_updated_on_new_message

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE@localhost/res1">>,escalus_tcp,<0.1260.0>,
          [{event_manager,<0.1259.0>},
           {server,<<"localhost">>},
           {username,<<"alicE">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.1259.0>},
            {server,<<"localhost">>},
            {username,<<"alicE">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"F1358BC86853D39C">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {inbox_SUITE,get_inbox,2,[{file,"inbox_SUITE.erl"},{line,929}]},
     {inbox_SUITE,'-timestamp_is_updated_on_new_message/1-fun-0-',2,
       [{file,"inbox_SUITE.erl"},{line,785}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1529}]},
     {test_server,run_test_case_eval1,6,...

Report log

mongoose-im · 2018-07-12T23:05:56Z

5139.1 / Erlang 19.3 / odbc_mssql_mnesia / eaa8f3d
Reports root/ big
OK: 21 / Failed: 0 / User-skipped: 0 / Auto-skipped: 0

mongoose-im · 2018-07-13T00:03:23Z

5140.1 / Erlang 19.3 / small_tests / ba4f881
Reports root / small

5140.5 / Erlang 19.3 / ldap_mnesia / ba4f881
Reports root/ big
OK: 1028 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0

5140.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / ba4f881
Reports root/ big
OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0

5140.3 / Erlang 19.3 / mysql_redis / ba4f881
Reports root/ big
OK: 2804 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0

5140.2 / Erlang 19.3 / internal_mnesia / ba4f881
Reports root/ big
OK: 1064 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0

5140.4 / Erlang 19.3 / odbc_mssql_mnesia / ba4f881
Reports root/ big
OK: 2818 / Failed: 0 / User-skipped: 208 / Auto-skipped: 0

5140.8 / Erlang 20.0 / pgsql_mnesia / ba4f881
Reports root/ big / small
OK: 2850 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0

5140.9 / Erlang 21.0 / riak_mnesia / ba4f881
Reports root/ big / small
OK: 1283 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0

mongoose-im · 2018-07-17T09:14:42Z

5160.1 / Erlang 19.3 / small_tests / a5902fb
Reports root / small

5160.5 / Erlang 19.3 / ldap_mnesia / a5902fb
Reports root/ big
OK: 1028 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0

5160.2 / Erlang 19.3 / internal_mnesia / a5902fb
Reports root/ big
OK: 1064 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0

5160.3 / Erlang 19.3 / mysql_redis / a5902fb
Reports root/ big
OK: 2806 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0

5160.4 / Erlang 19.3 / odbc_mssql_mnesia / a5902fb
Reports root/ big
OK: 2820 / Failed: 0 / User-skipped: 208 / Auto-skipped: 0

5160.8 / Erlang 20.0 / pgsql_mnesia / a5902fb
Reports root/ big / small
OK: 2852 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0

5160.9 / Erlang 21.0 / riak_mnesia / a5902fb
Reports root/ big / small
OK: 1283 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0

michalwski

Good job. I like the changes to tests the most. They are more readable now! To the code I had some questions and comments which may be worth addressing.

michalwski · 2018-07-17T10:03:39Z

include/mod_inbox.hrl

-{updated, non_neg_integer() |undefined} |
-{aborted, Reason :: term()} |
-{error, Reason :: string() | duplicate_key}.
+                               {updated, non_neg_integer() |undefined} |


missing space before undefined

michalwski · 2018-07-17T10:05:39Z

include/mod_inbox.hrl

@@ -1,15 +1,29 @@
 -type username() :: binary().


I know it's not you @fenek who introduced the type. It seems to me this type is the same as jid:luser/0

michalwski · 2018-07-17T10:05:58Z

include/mod_inbox.hrl

@@ -1,15 +1,29 @@
 -type username() :: binary().
+
 -type host() :: binary().


Is it the same as jid:lserver/0?

michalwski · 2018-07-17T10:06:46Z

include/mod_inbox.hrl

 -type content() :: binary().
+
 -type count() :: binary().


This is quite strange to me that count is of type binary. Just a comment :)

michalwski · 2018-07-17T10:07:44Z

src/inbox/mod_inbox.erl

@@ -56,6 +61,14 @@
                      Username :: jid:luser(),
                      Server :: jid:lserver().

+-type get_inbox_params() :: #{


👍 for the map here!

michalwski · 2018-07-17T10:11:47Z

src/inbox/mod_inbox.erl

+        order => asc | desc
+       }.
+
+-export_type([get_inbox_params/0]).


👍 for exporting the type. I really don't like types from .hrl files. I know they were not introduced in this PR.

michalwski · 2018-07-17T10:18:51Z

src/inbox/mod_inbox.erl

+    #xmlel{ name = <<"x">>, attrs = [{<<"xmlns">>, ?NS_XDATA}, {<<"type">>, <<"form">>}],
+            children = FormFields }.
+
+-spec text_single_form_field(Var :: binary()) -> exml:element().


I wonder if this kind of element builders are used in other places of MongooseIM. If so I hope they could be re-used. If not I think it'd be worth to extract text_single_form_field and other such builder function to a dedicated module (mongoose_xmpp?).

Will be probably covered by a separate XMPP library.

michalwski · 2018-07-17T10:26:19Z

src/inbox/mod_inbox.erl

-    {Acc, Res}.
+    case form_to_params(exml_query:subelement_with_ns(QueryEl, ?NS_XDATA)) of
+        {error, bad_request} ->
+            {Acc, IQ#iq{ type = error, sub_el = [ mongoose_xmpp_errors:bad_request() ] }};


I know that from security reasons returning just bad_request is ok. On the other hand, from my perspective, when client devs tries to adopt custom extensions (even if there is a doc how do to it). They got frustrated not knowing why there is a bad_request error. I suggest to extend the error with a text description saying, at least, in which field there was an issue.

I'm adding it to iteration 3. :)

michalwski · 2018-07-17T10:36:23Z

src/inbox/mod_inbox_utils.erl

@@ -50,7 +50,9 @@ write_to_sender_inbox(Server, Sender, Receiver, Packet) ->
    RemoteBareJid = jid:to_binary(jid:to_bare(Receiver)),
    %% no unread for a user because he writes new messages which assumes he read all previous messages.
    Count = integer_to_binary(0),
-    ok = mod_inbox_backend:set_inbox(Username, Server, RemoteBareJid, Content, Count, MsgId).
+    Timestamp = erlang:timestamp(),


Did you consider using os:system_time/1 which would return integer in the specified unit? It would eliminate calls to usec:from_now.

I got some strange results with os:system_time/1, at least on OTP 20.2:

9> f(), T = os:system_time(microsecond), T2 = T div 1000000, T1 = T2 div 1000000, T3 = T rem 1000000, calendar:now_to_datetime({T1, T2, T3}). {{2067,1,21},{12,8,16}}

So I'm sticking to erlang:timestamp() for now.

michalwski · 2018-07-17T10:42:19Z

doc/modules/mod_inbox.md

-</forwarded>
-</result>
+  <result xmlns="erlang-solutions.com:xmpp:inbox:0" unread="0" queryid="b6">
+    <forwarded xmlns="urn:xmpp:forward:0">


I wonder why there is the urn:xmpp:forward:0 namespace used instead of erlang-solutions.com:xmpp:inbox:0. That's just a question.

https://xmpp.org/extensions/xep-0297.html

Thanks @ludwikbukowski, this makes sense!

mongoose-im · 2018-07-17T14:02:14Z

5169.1 / Erlang 19.3 / small_tests / 29e6fcc
Reports root / small

5169.2 / Erlang 19.3 / internal_mnesia / 29e6fcc
Reports root/ big
OK: 1064 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0

5169.3 / Erlang 19.3 / mysql_redis / 29e6fcc
Reports root/ big
OK: 2809 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0

5169.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 29e6fcc
Reports root/ big
OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0

5169.4 / Erlang 19.3 / odbc_mssql_mnesia / 29e6fcc
Reports root/ big
OK: 2823 / Failed: 0 / User-skipped: 208 / Auto-skipped: 0

5169.5 / Erlang 19.3 / ldap_mnesia / 29e6fcc
Reports root/ big
OK: 1028 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0

goddammit · 2018-07-17T15:13:45Z

doc/modules/mod_inbox.md

+### Filtering and ordering
+
+Inbox query results may be filtered by time range and sorted by timestamp.
+By default, `mod_inbox` returns all conversations, most recently updated first.


By default, mod_inbox returns all conversations, listing the ones updated most recently first?

goddammit · 2018-07-17T15:14:19Z

doc/modules/mod_inbox.md

+* End date for the result set (variable `end`, value: ISO timestamp)
+* Order by timestamp (variable `order`, values: `asc`, `desc`)
+
+They are encoded inside standard XMPP [Data Forms](https://xmpp.org/extensions/xep-0004.html) format.


They are encoded inside a standard XMPP Data Forms format.

goddammit · 2018-07-17T15:14:37Z

doc/modules/mod_inbox.md

+
+They are encoded inside standard XMPP [Data Forms](https://xmpp.org/extensions/xep-0004.html) format.
+Dates must be formatted according to [XMPP Date and Time Profiles](https://xmpp.org/extensions/xep-0082.html).
+See example below.


+See the example below.

mongoose-im · 2018-07-17T15:29:00Z

5179.1 / Erlang 19.3 / small_tests / 10ff4a7
Reports root / small

5179.2 / Erlang 19.3 / internal_mnesia / 10ff4a7
Reports root/ big
OK: 1064 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0

5179.3 / Erlang 19.3 / mysql_redis / 10ff4a7
Reports root/ big
OK: 2809 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0

5179.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 10ff4a7
Reports root/ big
OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0

5179.4 / Erlang 19.3 / odbc_mssql_mnesia / 10ff4a7
Reports root/ big
OK: 2823 / Failed: 0 / User-skipped: 208 / Auto-skipped: 0

5179.5 / Erlang 19.3 / ldap_mnesia / 10ff4a7
Reports root/ big
OK: 1036 / Failed: 1 / User-skipped: 77 / Auto-skipped: 0

connect_SUITE:tls:auth_bind_pipelined_auth_failure

{error,{thrown,{timeout,auth_response}}}

Report log

5179.8 / Erlang 20.0 / pgsql_mnesia / 10ff4a7
Reports root/ big / small
OK: 2855 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0

5179.9 / Erlang 21.0 / riak_mnesia / 10ff4a7
Reports root/ big / small
OK: 1294 / Failed: 1 / User-skipped: 43 / Auto-skipped: 0

carboncopy_SUITE:all:unavailable_resources_dont_get_carbons

{error,{{assertion_failed,assert_many,false,[is_presence,is_presence],[],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1545}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1063}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,995}]}]}}

Report log

mongoose-im · 2018-07-19T11:33:24Z

5206.1 / Erlang 19.3 / small_tests / c5071c8
Reports root / small

Add timestamps to inbox results Fix timestamp unescape and specs in inbox Fix MSSQL Inbox timestamp insert Add ordering by timestamp to Inbox Add filtering by timestamp in mod_inbox Apply review comments for mod_inbox Fix logging in mod_inbox Update Inbox docs

mongoose-im · 2018-07-19T13:33:01Z

5210.1 / Erlang 19.3 / small_tests / de08377
Reports root / small

5210.2 / Erlang 19.3 / internal_mnesia / de08377
Reports root/ big
OK: 1066 / Failed: 0 / User-skipped: 45 / Auto-skipped: 0

5210.3 / Erlang 19.3 / mysql_redis / de08377
Reports root/ big
OK: 2820 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0

5210.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / de08377
Reports root/ big
OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0

5210.4 / Erlang 19.3 / odbc_mssql_mnesia / de08377
Reports root/ big
OK: 2834 / Failed: 0 / User-skipped: 208 / Auto-skipped: 0

5210.5 / Erlang 19.3 / ldap_mnesia / de08377
Reports root/ big
OK: 1030 / Failed: 0 / User-skipped: 81 / Auto-skipped: 0

5210.8 / Erlang 20.0 / pgsql_mnesia / de08377
Reports root/ big / small
OK: 2866 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0

5210.9 / Erlang 21.0 / riak_mnesia / de08377
Reports root/ big / small
OK: 1289 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0

michalwski · 2018-07-20T06:44:03Z

big_tests/tests/inbox.hrl

@@ -0,0 +1,8 @@
+-record(conv, {


Why record? I have this impression this was a map before rebasing, am I right?

No, it has always been a record. :)

michalwski · 2018-07-20T09:05:30Z

doc/modules/mod_inbox.md

-<inbox xmlns=”erlang-solutions.com:xmpp:inbox:0” queryid="b6"/>
+<iq type="set" id="10bca">
+  <inbox xmlns=”erlang-solutions.com:xmpp:inbox:0” queryid="b6">
+    <x xmlns='jabber:x:data' type='form'>


@fenek Is it possible to send and "empty" request like before? Or does client always have to provide start, end and order?

Yes, it is (but the IQ type must still be "set") possible to send empty query. Good catch, I'll clarify it in the doc.

fenek added WIP 🚧 waiting-for-ci labels Jul 9, 2018

fenek added this to the 3.0.0++ milestone Jul 9, 2018

fenek force-pushed the inbox-timestamp branch from 11bbf98 to 22fe305 Compare July 12, 2018 22:54

fenek force-pushed the inbox-timestamp branch from 22fe305 to 87d3664 Compare July 12, 2018 23:52

michalwski suggested changes Jul 17, 2018

View reviewed changes

fenek added waiting-for-review and removed WIP 🚧 labels Jul 17, 2018

goddammit reviewed Jul 17, 2018

View reviewed changes

michalwski approved these changes Jul 18, 2018

View reviewed changes

fenek force-pushed the inbox-timestamp branch from 612d6a7 to 506125a Compare July 19, 2018 11:20

fenek added 3 commits July 19, 2018 14:32

Fix bugs after inbox+timestamp rebase

948baaa

[skip ci] Fix language in mod_inbox.md

2fad432

fenek force-pushed the inbox-timestamp branch from b64a8a3 to 2fad432 Compare July 19, 2018 12:32

Update indexes in SQL schemas for inbox timestamps

75f9799

fenek removed the waiting-for-ci label Jul 19, 2018

michalwski reviewed Jul 20, 2018

View reviewed changes

[skip ci] Clarify data form usage in mod_inbox.md

f96e4ef

michalwski merged commit c3d2ffe into master Jul 20, 2018

michalwski deleted the inbox-timestamp branch July 20, 2018 10:13

		@@ -1,15 +1,29 @@
		-type username() :: binary().

		-type host() :: binary().

Timestamp support in mod_inbox #1970

Timestamp support in mod_inbox #1970

Conversation

fenek commented Jul 9, 2018 • edited Loading

mongoose-im commented Jul 9, 2018 • edited Loading

codecov bot commented Jul 9, 2018 • edited Loading

Codecov Report

mongoose-im commented Jul 9, 2018 • edited Loading

mongoose-im commented Jul 10, 2018 • edited Loading

mongoose-im commented Jul 12, 2018

mongoose-im commented Jul 12, 2018

mongoose-im commented Jul 12, 2018

mongoose-im commented Jul 13, 2018 • edited Loading

mongoose-im commented Jul 17, 2018 • edited Loading

michalwski left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mongoose-im commented Jul 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mongoose-im commented Jul 17, 2018 • edited Loading

mongoose-im commented Jul 19, 2018

mongoose-im commented Jul 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fenek commented Jul 9, 2018 •

edited

Loading

mongoose-im commented Jul 9, 2018 •

edited

Loading

codecov bot commented Jul 9, 2018 •

edited

Loading

mongoose-im commented Jul 9, 2018 •

edited

Loading

mongoose-im commented Jul 10, 2018 •

edited

Loading

mongoose-im commented Jul 13, 2018 •

edited

Loading

mongoose-im commented Jul 17, 2018 •

edited

Loading

mongoose-im commented Jul 17, 2018 •

edited

Loading

mongoose-im commented Jul 17, 2018 •

edited

Loading

mongoose-im commented Jul 19, 2018 •

edited

Loading