gdpr logs collection #2260
Merged
gdpr logs collection #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenek
requested changes
Apr 15, 2019
src/ejabberd_config.erl
Outdated
| @@ -54,6 +54,9 @@ | |||
| -export([config_state/0]). | |||
| -export([config_states/0]). | |||
|
|
|||
| -export([all_cluster_nodes/0, | |||
There was a problem hiding this comment.
all_cluster_nodes/0 not used in the PR eventually
Codecov Report
@@ Coverage Diff @@
## gdpr-retrieve #2260 +/- ##
==================================================
+ Coverage 30.73% 78.83% +48.09%
==================================================
Files 334 333 -1
Lines 28833 28798 -35
==================================================
+ Hits 8862 22703 +13841
+ Misses 19971 6095 -13876
Continue to review full report at Codecov.
|
DenysGonchar
force-pushed
the
gdpr-retrive-logs
branch
from
54a60b1
to
c0bb71a
Compare
fenek
force-pushed
the
gdpr-retrive-logs
branch
from
c0bb71a
to
c06fa89
Compare
fenek
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently get_logs_from_node/4 receives zipped logs from other nodes as rpc call return value. as agreed that is ok for the first version, if logs are too big this should be changed to some other delivery method (e.g. FTP)
for testing run: