Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] Basic IQ Handler tutorial automates Common Test. #2307

Merged
merged 2 commits into from
May 24, 2019

Conversation

NelsonVides
Copy link
Collaborator

mod_iq_handler is now loaded within the init_per_suite function and unloaded on the end_per_suite function, avoiding having to do so manually on the shell.

And a typo was corrected, in should_return_error it should call alice_bis.

mod_iq_handler is now loaded within the init_per_suite function and
unloaded on the end_per_suite function, avoiding having to do so
manually on the shell.

And a typo was corrected, in `should_return_error` it should call
`alice_bis`.
@NelsonVides NelsonVides requested a review from erszcz May 16, 2019 12:21
Copy link
Member

@erszcz erszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this looks good to me. Thanks!

@erszcz erszcz merged commit dff8d0f into master May 24, 2019
@erszcz erszcz deleted the docs-iq-handler-tutorial branch May 24, 2019 07:31
@fenek fenek added this to the MongooseIM 3.3.0++ milestone Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants