Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip ci] Lists are inline #2479

Merged
merged 1 commit into from
Sep 25, 2019
Merged

[skip ci] Lists are inline #2479

merged 1 commit into from
Sep 25, 2019

Conversation

Nyco
Copy link
Contributor

@Nyco Nyco commented Sep 25, 2019

There is a need for a carriage return on ReadTheDocs, forgot that, sorry...

Capture d’écran 2019-09-25 à 15 03 23

@Nyco
Lists are inline
2c8e741 
There is a need for a carriage return on ReadTheDocs, forgot that, sorry...
@NelsonVides
Copy link
Collaborator

@Nyco the [skip ci] tag works on the last commit's title, not on the PR name 🙂

NelsonVides
NelsonVides approved these changes Sep 25, 2019
View reviewed changes
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch, I also missed that completely on the review. I'll make sure not to miss it next time 😛

@NelsonVides NelsonVides merged commit ae551a9 into esl:master Sep 25, 2019
@fenek fenek added this to the 3.4.0++ milestone Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelsonVides NelsonVides NelsonVides approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Nyco @NelsonVides @fenek