MongoosePush API v3 mock #2549

michalwski · 2019-12-03T13:43:49Z

Proposed changes include:

allow to specify what HTTP status and body is returned to MongooseIM from MongoosePushMock
extend MongoosePushMock to accept requests to API v3

mongoose-im · 2019-12-03T14:49:50Z

7513.1 / Erlang 22.0 / small_tests / 815d86b
Reports root / small

7513.2 / Erlang 22.0 / internal_mnesia / 815d86b
Reports root/ big
OK: 1276 / Failed: 0 / User-skipped: 138 / Auto-skipped: 0

7513.3 / Erlang 22.0 / odbc_mssql_mnesia / 815d86b
Reports root/ big
OK: 2495 / Failed: 0 / User-skipped: 199 / Auto-skipped: 0

7513.4 / Erlang 22.0 / mysql_redis / 815d86b
Reports root/ big
OK: 2490 / Failed: 0 / User-skipped: 204 / Auto-skipped: 0

7513.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / 815d86b
Reports root/ big
OK: 328 / Failed: 0 / User-skipped: 28 / Auto-skipped: 0

7513.5 / Erlang 22.0 / riak_mnesia / 815d86b
Reports root/ big
OK: 1409 / Failed: 0 / User-skipped: 145 / Auto-skipped: 0

7513.6 / Erlang 22.0 / ldap_mnesia / 815d86b
Reports root/ big
OK: 1241 / Failed: 0 / User-skipped: 173 / Auto-skipped: 0

7513.9 / Erlang 21.3 / pgsql_mnesia / 815d86b
Reports root/ big / small
OK: 2508 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

codecov · 2019-12-03T16:19:15Z

Codecov Report

Merging #2549 into master will increase coverage by 0.36%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #2549      +/-   ##
==========================================
+ Coverage   78.68%   79.05%   +0.36%     
==========================================
  Files         343      343              
  Lines       29457    29463       +6     
==========================================
+ Hits        23179    23291     +112     
+ Misses       6278     6172     -106

Impacted Files	Coverage Δ
src/mod_push_service_mongoosepush.erl	`86.84% <77.77%> (+5.59%)`	⬆️
...c/global_distrib/mod_global_distrib_server_mgr.erl	`79.14% <0%> (-2.46%)`	⬇️
src/mod_bosh_socket.erl	`81.18% <0%> (-0.34%)`	⬇️
src/mod_muc_log.erl	`77.69% <0%> (ø)`	⬆️
src/mod_muc_room.erl	`77.79% <0%> (+0.29%)`	⬆️
src/pubsub/mod_pubsub_db_mnesia.erl	`94.42% <0%> (+0.42%)`	⬆️
src/config/mongoose_config_parser.erl	`74.41% <0%> (+0.46%)`	⬆️
src/rdbms/mongoose_rdbms.erl	`71.79% <0%> (+0.51%)`	⬆️
src/inbox/mod_inbox_rdbms.erl	`88.37% <0%> (+1.16%)`	⬆️
src/metrics/mongoose_metrics.erl	`92.99% <0%> (+1.27%)`	⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af5b77...b28c3db. Read the comment docs.

mongoose-im · 2019-12-04T14:33:46Z

7518.1 / Erlang 22.0 / small_tests / b476e8d
Reports root / small

7518.2 / Erlang 22.0 / internal_mnesia / b476e8d
Reports root/ big
OK: 1278 / Failed: 0 / User-skipped: 138 / Auto-skipped: 0

7518.3 / Erlang 22.0 / odbc_mssql_mnesia / b476e8d
Reports root/ big
OK: 2497 / Failed: 0 / User-skipped: 199 / Auto-skipped: 0

7518.4 / Erlang 22.0 / mysql_redis / b476e8d
Reports root/ big
OK: 2492 / Failed: 0 / User-skipped: 204 / Auto-skipped: 0

7518.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / b476e8d
Reports root/ big
OK: 328 / Failed: 0 / User-skipped: 28 / Auto-skipped: 0

7518.6 / Erlang 22.0 / ldap_mnesia / b476e8d
Reports root/ big
OK: 1243 / Failed: 0 / User-skipped: 173 / Auto-skipped: 0

7518.5 / Erlang 22.0 / riak_mnesia / b476e8d
Reports root/ big
OK: 1411 / Failed: 0 / User-skipped: 145 / Auto-skipped: 0

7518.9 / Erlang 21.3 / pgsql_mnesia / b476e8d
Reports root/ big / small
OK: 2510 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

mongoose-im · 2019-12-04T17:29:14Z

7520.1 / Erlang 22.0 / small_tests / 8abd2f1
Reports root / small

7520.2 / Erlang 22.0 / internal_mnesia / 8abd2f1
Reports root/ big
OK: 1278 / Failed: 0 / User-skipped: 138 / Auto-skipped: 0

7520.3 / Erlang 22.0 / odbc_mssql_mnesia / 8abd2f1
Reports root/ big
OK: 2497 / Failed: 0 / User-skipped: 199 / Auto-skipped: 0

7520.4 / Erlang 22.0 / mysql_redis / 8abd2f1
Reports root/ big
OK: 2492 / Failed: 0 / User-skipped: 204 / Auto-skipped: 0

7520.5 / Erlang 22.0 / riak_mnesia / 8abd2f1
Reports root/ big
OK: 1411 / Failed: 0 / User-skipped: 145 / Auto-skipped: 0

7520.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / 8abd2f1
Reports root/ big
OK: 328 / Failed: 0 / User-skipped: 28 / Auto-skipped: 0

7520.6 / Erlang 22.0 / ldap_mnesia / 8abd2f1
Reports root/ big
OK: 1243 / Failed: 0 / User-skipped: 173 / Auto-skipped: 0

7520.9 / Erlang 21.3 / pgsql_mnesia / 8abd2f1
Reports root/ big / small
OK: 2510 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

aleklisi

Thanks for PR, I fund no issues there.

fenek

Requires some update to migration guide about new default API version.

fenek · 2019-12-05T09:11:16Z

src/mod_push_service_mongoosepush.erl

+    {ok, <<"v2">>, v2};
+parse_api_version(_) ->
+    {error, not_supported}.
+
 %% Create notification for API v2


%% Create notification for API v2 and v3 :)

fenek · 2019-12-05T09:13:06Z

src/mod_push_service_mongoosepush.erl

 %% Create notification for API v2
-make_notification(v2, Notification, Options = #{<<"silent">> := <<"true">>}) ->
+make_notification(API, Notification, Options = #{<<"silent">> := <<"true">>})
+  when API =:= v2; API =:= v3 ->


I think this check is overzealous because we can't really have anything other than v2 and v3, right?

Currently that's true, the code will fail earlier. Previously we needed to check the version because the atom was created from the config option.

mongoose-im · 2019-12-05T13:08:32Z

7523.1 / Erlang 22.0 / small_tests / 20b953e
Reports root / small

7523.2 / Erlang 22.0 / internal_mnesia / 20b953e
Reports root/ big
OK: 1278 / Failed: 0 / User-skipped: 138 / Auto-skipped: 0

7523.3 / Erlang 22.0 / odbc_mssql_mnesia / 20b953e
Reports root/ big
OK: 2497 / Failed: 0 / User-skipped: 199 / Auto-skipped: 0

7523.4 / Erlang 22.0 / mysql_redis / 20b953e
Reports root/ big
OK: 2492 / Failed: 0 / User-skipped: 204 / Auto-skipped: 0

7523.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / 20b953e
Reports root/ big
OK: 328 / Failed: 0 / User-skipped: 28 / Auto-skipped: 0

7523.6 / Erlang 22.0 / ldap_mnesia / 20b953e
Reports root/ big
OK: 1243 / Failed: 0 / User-skipped: 173 / Auto-skipped: 0

7523.5 / Erlang 22.0 / riak_mnesia / 20b953e
Reports root/ big
OK: 1411 / Failed: 0 / User-skipped: 145 / Auto-skipped: 0

7523.9 / Erlang 21.3 / pgsql_mnesia / 20b953e
Reports root/ big / small
OK: 2510 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

fenek

Waiting for language check.

doc/migrations/3.5.0_3.5.0plus.md

doc/user-guide/Push-notifications.md

Co-Authored-By: K. Kraus <[email protected]>

michalwski added 2 commits December 3, 2019 14:29

allow to specify response code and body for mongoose_push mock

1f659c7

mongoose_push mock accepts requests to API v3

c5d9b20

Use MongoosePush API v3 by default in MongooseIM

1a505ae

michalwski added 2 commits December 4, 2019 15:43

recognise error code notifying about not registered device

76e3f67

return different error codes from mpush mock depending on api version

542fbe5

aleklisi approved these changes Dec 5, 2019

View reviewed changes

fenek requested changes Dec 5, 2019

View reviewed changes

address PR review comments

f0f7bfb

fenek approved these changes Dec 5, 2019

View reviewed changes

goddammit reviewed Dec 5, 2019

View reviewed changes

doc/migrations/3.5.0_3.5.0plus.md Outdated Show resolved Hide resolved

doc/user-guide/Push-notifications.md Outdated Show resolved Hide resolved

[skip ci] Apply language suggestions from code review

b28c3db

Co-Authored-By: K. Kraus <[email protected]>

fenek merged commit ed73be0 into master Dec 5, 2019

fenek deleted the mongoose-push-api-v3-mock branch December 5, 2019 18:14

michalwski mentioned this pull request Dec 5, 2019

Eradicate mod_push #2553

Merged

michalwski added this to the 3.6.0 milestone Jan 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MongoosePush API v3 mock #2549

MongoosePush API v3 mock #2549

michalwski commented Dec 3, 2019

mongoose-im commented Dec 3, 2019 •

edited

Loading

codecov bot commented Dec 3, 2019 •

edited

Loading

mongoose-im commented Dec 4, 2019 •

edited

Loading

mongoose-im commented Dec 4, 2019 •

edited

Loading

aleklisi left a comment

fenek left a comment

fenek Dec 5, 2019

fenek Dec 5, 2019

michalwski Dec 5, 2019

mongoose-im commented Dec 5, 2019 •

edited

Loading

fenek left a comment

MongoosePush API v3 mock #2549

MongoosePush API v3 mock #2549

Conversation

michalwski commented Dec 3, 2019

mongoose-im commented Dec 3, 2019 • edited Loading

codecov bot commented Dec 3, 2019 • edited Loading

Codecov Report

mongoose-im commented Dec 4, 2019 • edited Loading

mongoose-im commented Dec 4, 2019 • edited Loading

aleklisi left a comment

Choose a reason for hiding this comment

fenek left a comment

Choose a reason for hiding this comment

fenek Dec 5, 2019

Choose a reason for hiding this comment

fenek Dec 5, 2019

Choose a reason for hiding this comment

michalwski Dec 5, 2019

Choose a reason for hiding this comment

mongoose-im commented Dec 5, 2019 • edited Loading

fenek left a comment

Choose a reason for hiding this comment

mongoose-im commented Dec 3, 2019 •

edited

Loading

codecov bot commented Dec 3, 2019 •

edited

Loading

mongoose-im commented Dec 4, 2019 •

edited

Loading

mongoose-im commented Dec 4, 2019 •

edited

Loading

mongoose-im commented Dec 5, 2019 •

edited

Loading