Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use runuser instead of sudo #2617

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Use runuser instead of sudo #2617

merged 1 commit into from
Feb 3, 2020

Conversation

sebb7
Copy link
Contributor

@sebb7 sebb7 commented Feb 3, 2020

This PR addresses #2001.

@sebb7 sebb7 requested a review from michalwski February 3, 2020 08:32
@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 3, 2020

7875.1 / Erlang 22.0 / small_tests / ca5f4cb
Reports root / small


7875.2 / Erlang 22.0 / internal_mnesia / ca5f4cb
Reports root/ big
OK: 1378 / Failed: 0 / User-skipped: 155 / Auto-skipped: 0


7875.3 / Erlang 22.0 / odbc_mssql_mnesia / ca5f4cb
Reports root/ big
OK: 2613 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0


7875.4 / Erlang 22.0 / mysql_redis / ca5f4cb
Reports root/ big
OK: 2608 / Failed: 0 / User-skipped: 205 / Auto-skipped: 0


7875.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / ca5f4cb
Reports root/ big
OK: 328 / Failed: 0 / User-skipped: 28 / Auto-skipped: 0


7875.5 / Erlang 22.0 / riak_mnesia / ca5f4cb
Reports root/ big
OK: 1511 / Failed: 0 / User-skipped: 162 / Auto-skipped: 0


7875.6 / Erlang 22.0 / ldap_mnesia / ca5f4cb
Reports root/ big
OK: 1343 / Failed: 0 / User-skipped: 190 / Auto-skipped: 0


7875.9 / Erlang 21.3 / pgsql_mnesia / ca5f4cb
Reports root/ big / small
OK: 2626 / Failed: 0 / User-skipped: 187 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #2617 into master will increase coverage by 11.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2617       +/-   ##
===========================================
+ Coverage   66.87%   78.16%   +11.29%     
===========================================
  Files         355      355               
  Lines       30050    30050               
===========================================
+ Hits        20097    23490     +3393     
+ Misses       9953     6560     -3393     
Impacted Files Coverage Δ
src/pubsub/node_hometree.erl 77.77% <0.00%> (-5.56%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 75.51% <0.00%> (-2.05%) ⬇️
src/mod_muc_log.erl 77.69% <0.00%> (ø) ⬆️
src/pubsub/mod_pubsub.erl 71.95% <0.00%> (+0.12%) ⬆️
src/ejabberd_c2s.erl 88.51% <0.00%> (+0.22%) ⬆️
src/config/mongoose_config_parser.erl 74.64% <0.00%> (+0.46%) ⬆️
src/mod_roster.erl 79.58% <0.00%> (+0.69%) ⬆️
src/jlib.erl 82.84% <0.00%> (+0.83%) ⬆️
src/mod_muc_room.erl 77.54% <0.00%> (+0.87%) ⬆️
src/mod_bosh_socket.erl 82.17% <0.00%> (+0.99%) ⬆️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05275bd...135e855. Read the comment docs.

Copy link
Contributor

@michalwski michalwski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@michalwski michalwski merged commit bd31519 into master Feb 3, 2020
@michalwski michalwski deleted the replace-sudo-with-runuser branch February 3, 2020 13:10
@michalwski michalwski added this to the 3.6.1 milestone Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants