-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load nksip in parallel with big timeouts #2947
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #2947 +/- ##
==========================================
- Coverage 79.22% 79.19% -0.04%
==========================================
Files 377 377
Lines 32795 32795
==========================================
- Hits 25983 25973 -10
- Misses 6812 6822 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment from me.
Another thing: could we revert the original timeout for starting modules? It was changed only because of nksip, right?
Also revert commit 79f5ff0. "Extend timeout to start modules, nksip is slow"
6e07aa6
to
2277a86
Compare
This comment has been minimized.
This comment has been minimized.
2277a86
to
5f8b232
Compare
8740.1 / Erlang 23.0.3 / small_tests / 72e9edb 8740.2 / Erlang 23.0.3 / internal_mnesia / 72e9edb 8740.3 / Erlang 23.0.3 / odbc_mssql_mnesia / 72e9edb 8740.4 / Erlang 23.0.3 / mysql_redis / 72e9edb 8740.5 / Erlang 23.0.3 / riak_mnesia / 72e9edb 8740.6 / Erlang 23.0.3 / ldap_mnesia / 72e9edb 8740.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / 72e9edb 8740.9 / Erlang 22.3 / pgsql_mnesia / 72e9edb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the improvements!
No description provided.