Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load nksip in parallel with big timeouts #2947

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Conversation

NelsonVides
Copy link
Collaborator

No description provided.

@mongoose-im

This comment has been minimized.

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #2947 (5f8b232) into master (1aabb0c) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2947      +/-   ##
==========================================
- Coverage   79.22%   79.19%   -0.04%     
==========================================
  Files         377      377              
  Lines       32795    32795              
==========================================
- Hits        25983    25973      -10     
- Misses       6812     6822      +10     
Impacted Files Coverage Δ
src/mam/mod_mam_rdbms_prefs.erl 90.99% <0.00%> (-3.61%) ⬇️
src/rdbms/mongoose_rdbms.erl 65.71% <0.00%> (-1.91%) ⬇️
src/wpool/mongoose_wpool.erl 81.00% <0.00%> (-1.00%) ⬇️
src/mam/mod_mam_utils.erl 88.99% <0.00%> (-0.65%) ⬇️
src/mod_muc_log.erl 77.29% <0.00%> (ø)
src/mod_muc_room.erl 77.60% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aabb0c...5f8b232. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment from me.
Another thing: could we revert the original timeout for starting modules? It was changed only because of nksip, right?

big_tests/tests/jingle_SUITE.erl Outdated Show resolved Hide resolved
Also revert commit 79f5ff0.
"Extend timeout to start modules, nksip is slow"
@mongoose-im

This comment has been minimized.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Nov 21, 2020

8740.1 / Erlang 23.0.3 / small_tests / 72e9edb
Reports root / small


8740.2 / Erlang 23.0.3 / internal_mnesia / 72e9edb
Reports root/ big
OK: 1492 / Failed: 0 / User-skipped: 165 / Auto-skipped: 0


8740.3 / Erlang 23.0.3 / odbc_mssql_mnesia / 72e9edb
Reports root/ big
OK: 2765 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0


8740.4 / Erlang 23.0.3 / mysql_redis / 72e9edb
Reports root/ big
OK: 2760 / Failed: 0 / User-skipped: 233 / Auto-skipped: 0


8740.5 / Erlang 23.0.3 / riak_mnesia / 72e9edb
Reports root/ big
OK: 1626 / Failed: 0 / User-skipped: 177 / Auto-skipped: 0


8740.6 / Erlang 23.0.3 / ldap_mnesia / 72e9edb
Reports root/ big
OK: 1404 / Failed: 0 / User-skipped: 253 / Auto-skipped: 0


8740.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / 72e9edb
Reports root/ big
OK: 330 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


8740.9 / Erlang 22.3 / pgsql_mnesia / 72e9edb
Reports root/ big / small
OK: 2778 / Failed: 0 / User-skipped: 215 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the improvements!

@chrzaszcz chrzaszcz merged commit 2be82de into master Nov 23, 2020
@chrzaszcz chrzaszcz deleted the ci/fix_nksip_timeouts branch November 23, 2020 13:10
@leszke leszke added this to the 4.1.0 milestone Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants