Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove int_or_inf_or_atom from mod_stream_management #2988

Merged
merged 2 commits into from
Dec 22, 2020

Conversation

janciesla8818
Copy link
Contributor

This PR removes int_or_infinity_or_atom option type from TOML config spec. The idea is to introduce additional boolean options to the config of the module.

Before After
buffer_max = "no_buffer" buffer = false
ack_freq = "never" ack = false

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #2988 (07a15f7) into toml-config (6070a1b) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           toml-config    #2988      +/-   ##
===============================================
- Coverage        78.49%   78.44%   -0.05%     
===============================================
  Files              376      376              
  Lines            31660    31657       -3     
===============================================
- Hits             24850    24833      -17     
- Misses            6810     6824      +14     
Impacted Files Coverage Δ
src/config/mongoose_config_parser_toml.erl 82.90% <ø> (+0.24%) ⬆️
src/config/mongoose_config_validator_toml.erl 96.93% <ø> (+1.70%) ⬆️
src/mod_stream_management.erl 85.10% <100.00%> (+1.19%) ⬆️
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 75.14% <0.00%> (-2.26%) ⬇️
src/ejabberd_s2s_out.erl 57.89% <0.00%> (-1.84%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 86.60% <0.00%> (-1.79%) ⬇️
src/cassandra/mongoose_cassandra_worker.erl 71.69% <0.00%> (-0.95%) ⬇️
src/ejabberd_sm.erl 76.29% <0.00%> (-0.61%) ⬇️
src/mod_muc_room.erl 77.42% <0.00%> (-0.12%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6070a1b...07a15f7. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I left a few comments.

doc/modules/mod_stream_management.md Outdated Show resolved Hide resolved
doc/modules/mod_stream_management.md Outdated Show resolved Hide resolved
test/config_parser_SUITE.erl Outdated Show resolved Hide resolved
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrzaszcz chrzaszcz merged commit a46b9ab into toml-config Dec 22, 2020
@chrzaszcz chrzaszcz deleted the remove-redundant-types branch December 22, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants