Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTTP File Upload 0.2.5 support #2989

Merged
merged 6 commits into from
Jan 4, 2021

Conversation

fenek
Copy link
Member

@fenek fenek commented Dec 21, 2020

This PR removes support for the outdated 0.2.5 specification of HTTP File Upload.

  • Module updated
  • Tests updated
  • Docs updated (module & migration guide)

@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 21, 2020

8940.1 / Erlang 23.0.3 / small_tests / 45faab7
Reports root / small


8940.2 / Erlang 23.0.3 / internal_mnesia / 45faab7
Reports root/ big
OK: 1495 / Failed: 0 / User-skipped: 168 / Auto-skipped: 0


8940.4 / Erlang 23.0.3 / mysql_redis / 45faab7
Reports root/ big
OK: 2766 / Failed: 0 / User-skipped: 233 / Auto-skipped: 0


8940.3 / Erlang 23.0.3 / odbc_mssql_mnesia / 45faab7
Reports root/ big
OK: 2771 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0


8940.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / 45faab7
Reports root/ big
OK: 330 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


8940.6 / Erlang 23.0.3 / ldap_mnesia / 45faab7
Reports root/ big
OK: 1405 / Failed: 0 / User-skipped: 258 / Auto-skipped: 0


8940.5 / Erlang 23.0.3 / riak_mnesia / 45faab7
Reports root/ big
OK: 1629 / Failed: 0 / User-skipped: 180 / Auto-skipped: 0


8940.9 / Erlang 22.3 / pgsql_mnesia / 45faab7
Reports root/ big / small
OK: 2784 / Failed: 0 / User-skipped: 215 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #2989 (726e11e) into master (24f4236) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2989      +/-   ##
==========================================
- Coverage   79.17%   79.13%   -0.05%     
==========================================
  Files         377      377              
  Lines       32846    32840       -6     
==========================================
- Hits        26005    25987      -18     
- Misses       6841     6853      +12     
Impacted Files Coverage Δ
src/http_upload/mod_http_upload.erl 90.36% <100.00%> (-0.65%) ⬇️
src/mongoose_tcp_listener.erl 76.59% <0.00%> (-4.26%) ⬇️
src/ejabberd_s2s_out.erl 58.35% <0.00%> (-1.38%) ⬇️
src/pubsub/mod_pubsub.erl 71.87% <0.00%> (-0.30%) ⬇️
src/mod_muc_room.erl 77.37% <0.00%> (-0.18%) ⬇️
src/mod_muc_log.erl 77.55% <0.00%> (+0.25%) ⬆️
src/global_distrib/mod_global_distrib_utils.erl 66.03% <0.00%> (+0.94%) ⬆️
src/ejabberd_local.erl 73.13% <0.00%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f4236...bab8ed9. Read the comment docs.

Copy link
Contributor

@leszke leszke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left one minor comment only

src/http_upload/mod_http_upload.erl Outdated Show resolved Hide resolved
@chrzaszcz chrzaszcz merged commit 1298aef into master Jan 4, 2021
@chrzaszcz chrzaszcz deleted the mim-1324.remove.http.upload.025 branch January 4, 2021 09:52
@leszke leszke added this to the 4.1.0 milestone Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants