-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip ci] Reference about store_groupchat_messages option in mod_offline added #2992
[skip ci] Reference about store_groupchat_messages option in mod_offline added #2992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR. historically there are several reasons why store_groupchat_messages
option is not documented:
- XEP-0160 doesn't specify this functionality, because the classic MUC even doesn't send the messages to offline users.
- As this will not work as expected with the classic MUC, the option makes sense only with MUC-light.
- XEP-0160 is not recommended way of storing offline messages (especially group-chat messages), better use message archive with MUC storage enabled.
So this option is rather confusing than brings any benefit, it's kept for compatibility reasons.
So let's either keep it not documented or fully document it.
Although the use of
If these scenarios are considered of interest, I can try to fully document, referring to explicitly to MUC-light case as DenysGonchar rightly pointed out to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope that it is adequately documented now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me 👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks for your contribution
This PR adds documentation for mod_offline, regarding the option store_groupchat_messages. #2879