Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report lcov file to coveralls using gh action #2993

Merged
merged 2 commits into from
Jan 5, 2021
Merged

report lcov file to coveralls using gh action #2993

merged 2 commits into from
Jan 5, 2021

Conversation

DenysGonchar
Copy link
Collaborator

Use Coveralls GH action for reporting coverage

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 4, 2021 •
edited
Loading

8974.1 / Erlang 23.0.3 / small_tests / 676711f
Reports root / small

8974.2 / Erlang 23.0.3 / internal_mnesia / 676711f
Reports root/ big
OK: 1495 / Failed: 0 / User-skipped: 168 / Auto-skipped: 0

8974.4 / Erlang 23.0.3 / mysql_redis / 676711f
Reports root/ big
OK: 2766 / Failed: 0 / User-skipped: 233 / Auto-skipped: 0

8974.3 / Erlang 23.0.3 / odbc_mssql_mnesia / 676711f
Reports root/ big
OK: 2771 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

8974.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / 676711f
Reports root/ big
OK: 330 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

8974.5 / Erlang 23.0.3 / riak_mnesia / 676711f
Reports root/ big
OK: 1629 / Failed: 0 / User-skipped: 180 / Auto-skipped: 0

8974.6 / Erlang 23.0.3 / ldap_mnesia / 676711f
Reports root/ big
OK: 1405 / Failed: 0 / User-skipped: 258 / Auto-skipped: 0

8974.9 / Erlang 22.3 / pgsql_mnesia / 676711f
Reports root/ big / small
OK: 2784 / Failed: 0 / User-skipped: 215 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jan 4, 2021 •
edited
Loading

Codecov Report

Merging #2993 (a9c035d) into master (c2e3edd) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2993      +/-   ##
==========================================
+ Coverage   79.11%   79.13%   +0.02%     
==========================================
  Files         377      377              
  Lines       32846    32846              
==========================================
+ Hits        25985    25994       +9     
+ Misses       6861     6852       -9
Impacted Files Coverage Δ
src/ejabberd_s2s_out.erl 57.89% <0.00%> (-1.84%) ⬇️
src/ejabberd_sm.erl 75.98% <0.00%> (-0.31%) ⬇️
src/mod_muc_room.erl 77.37% <0.00%> (-0.18%) ⬇️
src/mod_muc_log.erl 77.29% <0.00%> (ø)
src/ejabberd_c2s.erl 89.34% <0.00%> (+0.07%) ⬆️
src/pubsub/mod_pubsub_db_mnesia.erl 92.82% <0.00%> (+0.42%) ⬆️
src/mam/mod_mam_utils.erl 89.64% <0.00%> (+0.64%) ⬆️
src/wpool/mongoose_wpool.erl 82.00% <0.00%> (+1.00%) ⬆️
src/ejabberd_local.erl 73.13% <0.00%> (+1.49%) ⬆️
src/mam/mod_mam_elasticsearch_arch.erl 88.39% <0.00%> (+1.78%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e3edd...b1bb0ef. Read the comment docs.

chrzaszcz
chrzaszcz reviewed Jan 4, 2021
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question from me.

rebar.config.script
Comment on lines -87 to -107
MaybeConfigureCoveralls = fun(CONFIG) ->
case {os:getenv("GITHUB_ACTIONS"), os:getenv("GITHUB_TOKEN")} of
{"true", Token} when is_list(Token) ->
CONFIG1 = [{coveralls_repo_token, Token},
{coveralls_service_job_id, os:getenv("GITHUB_RUN_ID")},
{coveralls_commit_sha, os:getenv("GITHUB_SHA")} | CONFIG],
case os:getenv("GITHUB_EVENT_NAME") =:= "pull_request" andalso
string:tokens(os:getenv("GITHUB_REF"), "/") of
[_, "pull", PRNO, _] ->
[{coveralls_service_pull_request, PRNO} | CONFIG1];
_ ->
CONFIG1
end;
_ ->
CONFIG
end
end,

Config0 = MaybeConfigureCoveralls(CONFIG),
Config1 = SetupIncludedApps(Config0, EnvApps),
MaybeFIPSSupport(Config1).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain in the commit message why it is not needed anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more note, let's first merge https://github.com/esl/rebar3_codecov/pull/3/files and switch back to the commit version selection for rebar3 codecov plugin before we merge this PR

@DenysGonchar
report lcov file to coveralls using gh action
a9c035d 
coveralls rebar3 plugin fails on parallel reporting for master branch.
so switching from rebar3 plugin to official coveralls GH action for
coverage reporting.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 4, 2021 •
edited
Loading

8977.1 / Erlang 23.0.3 / small_tests / 257e579
Reports root / small

8977.2 / Erlang 23.0.3 / internal_mnesia / 257e579
Reports root/ big
OK: 1495 / Failed: 0 / User-skipped: 168 / Auto-skipped: 0

8977.4 / Erlang 23.0.3 / mysql_redis / 257e579
Reports root/ big
OK: 2766 / Failed: 0 / User-skipped: 233 / Auto-skipped: 0

8977.3 / Erlang 23.0.3 / odbc_mssql_mnesia / 257e579
Reports root/ big
OK: 2771 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

8977.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / 257e579
Reports root/ big
OK: 330 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

8977.5 / Erlang 23.0.3 / riak_mnesia / 257e579
Reports root/ big
OK: 1629 / Failed: 0 / User-skipped: 180 / Auto-skipped: 0

8977.6 / Erlang 23.0.3 / ldap_mnesia / 257e579
Reports root/ big
OK: 1405 / Failed: 0 / User-skipped: 258 / Auto-skipped: 0

8977.9 / Erlang 22.3 / pgsql_mnesia / 257e579
Reports root/ big / small
OK: 2784 / Failed: 0 / User-skipped: 215 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 5, 2021 •
edited
Loading

8978.1 / Erlang 23.0.3 / small_tests / a6da662
Reports root / small

8978.2 / Erlang 23.0.3 / internal_mnesia / a6da662
Reports root/ big
OK: 1495 / Failed: 0 / User-skipped: 168 / Auto-skipped: 0

8978.3 / Erlang 23.0.3 / odbc_mssql_mnesia / a6da662
Reports root/ big
OK: 2771 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

8978.5 / Erlang 23.0.3 / riak_mnesia / a6da662
Reports root/ big
OK: 1629 / Failed: 0 / User-skipped: 180 / Auto-skipped: 0

8978.6 / Erlang 23.0.3 / ldap_mnesia / a6da662
Reports root/ big
OK: 1405 / Failed: 0 / User-skipped: 258 / Auto-skipped: 0

8978.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / a6da662
Reports root/ big
OK: 330 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

8978.9 / Erlang 22.3 / pgsql_mnesia / a6da662
Reports root/ big / small
OK: 2784 / Failed: 0 / User-skipped: 215 / Auto-skipped: 0

chrzaszcz
chrzaszcz approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrzaszcz chrzaszcz merged commit d5c1586 into master Jan 5, 2021
@chrzaszcz chrzaszcz deleted the imporve-coveralls-reporting branch January 5, 2021 14:44
@leszke leszke added this to the 4.1.0 milestone Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrzaszcz chrzaszcz chrzaszcz approved these changes

@arcusfelis arcusfelis Awaiting requested review from arcusfelis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@DenysGonchar @mongoose-im @chrzaszcz @leszke