Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the name of the protocol variable #3000

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Fixed the name of the protocol variable #3000

merged 2 commits into from
Jan 13, 2021

Conversation

HernanRivasAcosta
Copy link
Member

Fixed the name of the protocol variable in the example.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 7, 2021 •
edited
Loading

8986.1 / Erlang 23.0.3 / small_tests / 3fa54d8
Reports root / small

8986.2 / Erlang 23.0.3 / internal_mnesia / 3fa54d8
Reports root/ big
OK: 1495 / Failed: 0 / User-skipped: 168 / Auto-skipped: 0

8986.3 / Erlang 23.0.3 / odbc_mssql_mnesia / 3fa54d8
Reports root/ big
OK: 2771 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

8986.4 / Erlang 23.0.3 / mysql_redis / 3fa54d8
Reports root/ big
OK: 2766 / Failed: 0 / User-skipped: 233 / Auto-skipped: 0

8986.5 / Erlang 23.0.3 / riak_mnesia / 3fa54d8
Reports root/ big
OK: 1629 / Failed: 0 / User-skipped: 180 / Auto-skipped: 0

8986.6 / Erlang 23.0.3 / ldap_mnesia / 3fa54d8
Reports root/ big
OK: 1405 / Failed: 0 / User-skipped: 258 / Auto-skipped: 0

8986.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / 3fa54d8
Reports root/ big
OK: 330 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

8986.9 / Erlang 22.3 / pgsql_mnesia / 3fa54d8
Reports root/ big / small
OK: 2784 / Failed: 0 / User-skipped: 215 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jan 7, 2021 •
edited
Loading

Codecov Report

Merging #3000 (232e340) into master (d5c1586) will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3000      +/-   ##
==========================================
- Coverage   79.12%   78.81%   -0.32%     
==========================================
  Files         377      377              
  Lines       32840    32840              
==========================================
- Hits        25986    25884     -102     
- Misses       6854     6956     +102
Impacted Files Coverage Δ
src/rdbms/rdbms_queries_mssql.erl 0.00% <0.00%> (-100.00%) ⬇️
src/inbox/mod_inbox_rdbms_mssql.erl 0.00% <0.00%> (-100.00%) ⬇️
src/rdbms/mongoose_rdbms_odbc.erl 10.58% <0.00%> (-67.06%) ⬇️
src/ejabberd_rdbms.erl 88.88% <0.00%> (-11.12%) ⬇️
src/rdbms/rdbms_queries.erl 75.00% <0.00%> (-7.56%) ⬇️
src/pubsub/mod_pubsub_db_rdbms_sql.erl 89.21% <0.00%> (-4.91%) ⬇️
src/wpool/mongoose_wpool_rdbms.erl 79.16% <0.00%> (-4.17%) ⬇️
src/mod_vcard_rdbms.erl 71.14% <0.00%> (-3.36%) ⬇️
src/ejabberd_local.erl 71.64% <0.00%> (-1.50%) ⬇️
src/mam/mod_mam_rdbms_user.erl 63.01% <0.00%> (-1.37%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5c1586...0fe7c41. Read the comment docs.

leszke
leszke reviewed Jan 8, 2021
View reviewed changes
Copy link
Contributor

@leszke leszke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hernan,
Thanks for catching this. There's still one small thing though to be done here :)

doc/authentication-methods/anonymous.md
@@ -30,5 +30,5 @@ Specifies the SASL mechanisms supported by the `anonymous` authentication method

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 17 up there, could you also update the example to protocol = ...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch, missed that one.

@HernanRivasAcosta
Update anonymous.md
0fe7c41 
Fixed another place where the variable had the wrong name.
leszke
leszke approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@leszke leszke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 8, 2021 •
edited
Loading

9005.1 / Erlang 23.0.3 / small_tests / 2eba21c
Reports root / small

9005.2 / Erlang 23.0.3 / internal_mnesia / 2eba21c
Reports root/ big
OK: 1503 / Failed: 0 / User-skipped: 160 / Auto-skipped: 0

9005.3 / Erlang 23.0.3 / odbc_mssql_mnesia / 2eba21c
Reports root/ big
OK: 2764 / Failed: 21 / User-skipped: 228 / Auto-skipped: 0

muc_http_api_SUITE:positive:create_room 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:positive:send_message_to_room 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:positive:invite_online_user_to_room 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:positive:multiparty_multiprotocol 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:positive:kick_user_from_room 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:positive:create_room 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:positive:send_message_to_room 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:positive:invite_online_user_to_room 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:positive:multiparty_multiprotocol 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:positive:kick_user_from_room 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:positive:create_room 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:positive:send_message_to_room 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:positive:invite_online_user_to_room 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:positive:multiparty_multiprotocol 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:positive:kick_user_from_room 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:negative:failed_invites 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:negative:failed_messages 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:negative:failed_messages 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:negative:failed_invites 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:negative:failed_invites 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

muc_http_api_SUITE:negative:failed_messages 
{'EXIT',
  {fw_error,
    {ct_framework,error_notification,
      {{case_clause,[]},
       [{ct_framework,error_notification,4,
          [{file,"ct_framework.erl"},{line,997}]},
        {test_server_sup,framework_call,4,
          [{file,"test_server_sup.erl"},{line,778}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1268}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1195}]}]}}}}

Report log

9005.4 / Erlang 23.0.3 / mysql_redis / 2eba21c
Reports root/ big
OK: 2766 / Failed: 0 / User-skipped: 233 / Auto-skipped: 0

9005.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / 2eba21c
Reports root/ big
OK: 330 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

9005.6 / Erlang 23.0.3 / ldap_mnesia / 2eba21c
Reports root/ big
OK: 1405 / Failed: 0 / User-skipped: 258 / Auto-skipped: 0

9005.5 / Erlang 23.0.3 / riak_mnesia / 2eba21c
Reports root/ big
OK: 1629 / Failed: 0 / User-skipped: 180 / Auto-skipped: 0

9005.9 / Erlang 22.3 / pgsql_mnesia / 2eba21c
Reports root/ big / small
OK: 2784 / Failed: 0 / User-skipped: 215 / Auto-skipped: 0

chrzaszcz
chrzaszcz approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@chrzaszcz chrzaszcz merged commit dc82e75 into master Jan 13, 2021
@chrzaszcz chrzaszcz deleted the HernanRivasAcosta-patch-1 branch January 13, 2021 10:30
@leszke leszke added this to the 4.1.0 milestone Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leszke leszke leszke approved these changes

@chrzaszcz chrzaszcz chrzaszcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@HernanRivasAcosta @mongoose-im @chrzaszcz @leszke