Update migration guide with TOML changes #3007
Conversation
Codecov Report
@@ Coverage Diff @@
## toml-config #3007 +/- ##
================================================
- Coverage 78.51% 61.55% -16.97%
================================================
Files 376 376
Lines 31574 31574
================================================
- Hits 24790 19434 -5356
- Misses 6784 12140 +5356
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I think the migration guide (contrary to the changelog) should only list the changes that require actions from the user. This is why I pointed out all the changes that actually are only doc corrections - I think they shouldn't be listed here as they require no action from the user. If they had a correct setting, it remains correct, so no there is no migration.
Regarding the language - I pointed out a few missing articles, which I am sure about.
|
|
||
| * `mod_global_distrib.connections.tls.enabled`: the flag was removed, TLS is enabled by providing the [`cacertfile`](../../modules/mod_global_distrib/#modulesmod_global_distribconnectionstlscacertfile) and [`certfile`](../../modules/mod_global_distrib/#modulesmod_global_distribconnectionstlscertfile) options | ||
|
|
||
| * [`mod_http_upload.max_file_size`](../../modules/mod_http_upload/#modulesmod_http_uploadmax_file_size): `undefined` is no longer allowed |
There was a problem hiding this comment.
Just a note: Actually it seems that this was already changed (accidentally?) when introducing TOML, but I believe there were no comments about it, so let's keep it, no changes needed here.
leszke
force-pushed
the
update-migration_guide
branch
from
5752230
to
2c00f85
Compare
Basically I went through the output of
git diff master toml-config doc/command and wrote it down, already excluding couple of type alignments. I also added missing link to the newest migration guide's chapter.