-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rolling upgrade of MongooseIM cluster #3012
Conversation
9031.1 / Erlang 23.0.3 / small_tests / 05e73c1 9031.2 / Erlang 23.0.3 / internal_mnesia / 05e73c1 9031.3 / Erlang 23.0.3 / odbc_mssql_mnesia / 05e73c1 9031.4 / Erlang 23.0.3 / mysql_redis / 05e73c1 9031.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / 05e73c1 9031.5 / Erlang 23.0.3 / riak_mnesia / 05e73c1 9031.6 / Erlang 23.0.3 / ldap_mnesia / 05e73c1 9031.9 / Erlang 22.3 / pgsql_mnesia / 05e73c1 |
Codecov Report
@@ Coverage Diff @@
## master #3012 +/- ##
=======================================
Coverage 78.50% 78.51%
=======================================
Files 376 376
Lines 31502 31502
=======================================
+ Hits 24732 24735 +3
+ Misses 6770 6767 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments and the part that might need sorting out is the recommended node restart order. Could you also make sure the problem still exists with the current Mnesia?
If you tested the procedure according to the doc, I think there's no need to repeat this again during review.
9037.1 / Erlang 23.0.3 / small_tests / edfb9bb 9037.3 / Erlang 23.0.3 / odbc_mssql_mnesia / edfb9bb 9037.4 / Erlang 23.0.3 / mysql_redis / edfb9bb 9037.5 / Erlang 23.0.3 / riak_mnesia / edfb9bb 9037.6 / Erlang 23.0.3 / ldap_mnesia / edfb9bb 9037.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / edfb9bb 9037.9 / Erlang 22.3 / pgsql_mnesia / edfb9bb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, looks good, a few comments from me. Keeping in mind that this task precedes dropping config reload, I think we could improve this part.
9041.1 / Erlang 23.0.3 / small_tests / 73004f7 9041.2 / Erlang 23.0.3 / internal_mnesia / 73004f7 9041.3 / Erlang 23.0.3 / odbc_mssql_mnesia / 73004f7 9041.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / 73004f7 9041.6 / Erlang 23.0.3 / ldap_mnesia / 73004f7 9041.5 / Erlang 23.0.3 / riak_mnesia / 73004f7 9041.9 / Erlang 22.3 / pgsql_mnesia / 73004f7 |
This PR addresses add a sections in the documentation that describe: