Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling upgrade of MongooseIM cluster #3012

Merged
merged 5 commits into from
Jan 25, 2021
Merged

Rolling upgrade of MongooseIM cluster #3012

merged 5 commits into from
Jan 25, 2021

Conversation

janciesla8818
Copy link
Contributor

This PR addresses add a sections in the documentation that describe:

  • basic process of rolling upgrade for MongooseIM cluster
  • cluster restart considerations

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 18, 2021

9031.1 / Erlang 23.0.3 / small_tests / 05e73c1
Reports root / small


9031.2 / Erlang 23.0.3 / internal_mnesia / 05e73c1
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 161 / Auto-skipped: 0


9031.3 / Erlang 23.0.3 / odbc_mssql_mnesia / 05e73c1
Reports root/ big
OK: 2770 / Failed: 0 / User-skipped: 229 / Auto-skipped: 0


9031.4 / Erlang 23.0.3 / mysql_redis / 05e73c1
Reports root/ big
OK: 2765 / Failed: 0 / User-skipped: 234 / Auto-skipped: 0


9031.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / 05e73c1
Reports root/ big
OK: 331 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


9031.5 / Erlang 23.0.3 / riak_mnesia / 05e73c1
Reports root/ big
OK: 1628 / Failed: 0 / User-skipped: 181 / Auto-skipped: 0


9031.6 / Erlang 23.0.3 / ldap_mnesia / 05e73c1
Reports root/ big
OK: 1404 / Failed: 0 / User-skipped: 259 / Auto-skipped: 0


9031.9 / Erlang 22.3 / pgsql_mnesia / 05e73c1
Reports root/ big / small
OK: 2783 / Failed: 0 / User-skipped: 216 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #3012 (5446543) into master (6171e56) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3012   +/-   ##
=======================================
  Coverage   78.50%   78.51%           
=======================================
  Files         376      376           
  Lines       31502    31502           
=======================================
+ Hits        24732    24735    +3     
+ Misses       6770     6767    -3     
Impacted Files Coverage Δ
src/cassandra/mongoose_cassandra_worker.erl 70.75% <0.00%> (-4.25%) ⬇️
src/global_distrib/mod_global_distrib_utils.erl 65.09% <0.00%> (-0.95%) ⬇️
src/mod_roster.erl 77.49% <0.00%> (-0.47%) ⬇️
src/mod_muc_room.erl 77.31% <0.00%> (+0.05%) ⬆️
src/pubsub/mod_pubsub_db_mnesia.erl 92.82% <0.00%> (+0.42%) ⬆️
src/mod_bosh_socket.erl 79.19% <0.00%> (+1.55%) ⬆️
src/mam/mod_mam_elasticsearch_arch.erl 88.39% <0.00%> (+1.78%) ⬆️
src/mod_bosh.erl 93.91% <0.00%> (+2.02%) ⬆️
src/elasticsearch/mongoose_elasticsearch.erl 84.61% <0.00%> (+7.69%) ⬆️
src/ejabberd.erl 55.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6171e56...f8dd54b. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments and the part that might need sorting out is the recommended node restart order. Could you also make sure the problem still exists with the current Mnesia?

If you tested the procedure according to the doc, I think there's no need to repeat this again during review.

doc/operation-and-maintenance/Cluster-restart.md Outdated Show resolved Hide resolved
doc/operation-and-maintenance/Rolling-upgrade.md Outdated Show resolved Hide resolved
doc/operation-and-maintenance/Rolling-upgrade.md Outdated Show resolved Hide resolved
doc/operation-and-maintenance/Cluster-restart.md Outdated Show resolved Hide resolved
doc/operation-and-maintenance/Rolling-upgrade.md Outdated Show resolved Hide resolved
doc/operation-and-maintenance/Rolling-upgrade.md Outdated Show resolved Hide resolved
doc/operation-and-maintenance/Rolling-upgrade.md Outdated Show resolved Hide resolved
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 21, 2021

9037.1 / Erlang 23.0.3 / small_tests / edfb9bb
Reports root / small


9037.3 / Erlang 23.0.3 / odbc_mssql_mnesia / edfb9bb
Reports root/ big
OK: 2770 / Failed: 0 / User-skipped: 229 / Auto-skipped: 0


9037.4 / Erlang 23.0.3 / mysql_redis / edfb9bb
Reports root/ big
OK: 2765 / Failed: 0 / User-skipped: 234 / Auto-skipped: 0


9037.5 / Erlang 23.0.3 / riak_mnesia / edfb9bb
Reports root/ big
OK: 1628 / Failed: 0 / User-skipped: 181 / Auto-skipped: 0


9037.6 / Erlang 23.0.3 / ldap_mnesia / edfb9bb
Reports root/ big
OK: 1404 / Failed: 0 / User-skipped: 259 / Auto-skipped: 0


9037.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / edfb9bb
Reports root/ big
OK: 331 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


9037.9 / Erlang 22.3 / pgsql_mnesia / edfb9bb
Reports root/ big / small
OK: 2783 / Failed: 0 / User-skipped: 216 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looks good, a few comments from me. Keeping in mind that this task precedes dropping config reload, I think we could improve this part.

doc/operation-and-maintenance/Cluster-restart.md Outdated Show resolved Hide resolved
doc/operation-and-maintenance/Cluster-restart.md Outdated Show resolved Hide resolved
doc/operation-and-maintenance/Rolling-upgrade.md Outdated Show resolved Hide resolved
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 25, 2021

9041.1 / Erlang 23.0.3 / small_tests / 73004f7
Reports root / small


9041.2 / Erlang 23.0.3 / internal_mnesia / 73004f7
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 161 / Auto-skipped: 0


9041.3 / Erlang 23.0.3 / odbc_mssql_mnesia / 73004f7
Reports root/ big
OK: 2770 / Failed: 0 / User-skipped: 229 / Auto-skipped: 0


9041.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / 73004f7
Reports root/ big
OK: 331 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


9041.6 / Erlang 23.0.3 / ldap_mnesia / 73004f7
Reports root/ big
OK: 1404 / Failed: 0 / User-skipped: 259 / Auto-skipped: 0


9041.5 / Erlang 23.0.3 / riak_mnesia / 73004f7
Reports root/ big
OK: 1628 / Failed: 0 / User-skipped: 181 / Auto-skipped: 0


9041.9 / Erlang 22.3 / pgsql_mnesia / 73004f7
Reports root/ big / small
OK: 2783 / Failed: 0 / User-skipped: 216 / Auto-skipped: 0

@chrzaszcz chrzaszcz merged commit 32c4273 into master Jan 25, 2021
@chrzaszcz chrzaszcz deleted the rolling_upgrade branch January 25, 2021 16:41
@leszke leszke added this to the 4.1.0 milestone Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants