Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify some deprecated uses of http_uri #3026

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Simplify some deprecated uses of http_uri #3026

merged 1 commit into from
Feb 8, 2021

Conversation

NelsonVides
Copy link
Collaborator

http_uri was deprecated since OTP21. This is in general to clean-up code for ejabberd_auth_http.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 4, 2021

9073.1 / Erlang 23.0.3 / small_tests / 572f39f
Reports root / small


9073.2 / Erlang 23.0.3 / internal_mnesia / 572f39f
Reports root/ big
OK: 1503 / Failed: 0 / User-skipped: 161 / Auto-skipped: 0


9073.3 / Erlang 23.0.3 / odbc_mssql_mnesia / 572f39f
Reports root/ big
OK: 2771 / Failed: 0 / User-skipped: 229 / Auto-skipped: 0


9073.4 / Erlang 23.0.3 / mysql_redis / 572f39f
Reports root/ big
OK: 2766 / Failed: 0 / User-skipped: 234 / Auto-skipped: 0


9073.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / 572f39f
Reports root/ big
OK: 331 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


9073.6 / Erlang 23.0.3 / ldap_mnesia / 572f39f
Reports root/ big
OK: 1405 / Failed: 0 / User-skipped: 259 / Auto-skipped: 0


9073.5 / Erlang 23.0.3 / riak_mnesia / 572f39f
Reports root/ big
OK: 1629 / Failed: 0 / User-skipped: 181 / Auto-skipped: 0


9073.9 / Erlang 22.3 / pgsql_mnesia / 572f39f
Reports root/ big / small
OK: 2784 / Failed: 0 / User-skipped: 216 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #3026 (6c37f73) into master (c7935ad) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3026      +/-   ##
==========================================
+ Coverage   78.53%   78.60%   +0.06%     
==========================================
  Files         376      376              
  Lines       31488    31482       -6     
==========================================
+ Hits        24729    24746      +17     
+ Misses       6759     6736      -23     
Impacted Files Coverage Δ
src/auth/ejabberd_auth_http.erl 68.57% <100.00%> (-0.88%) ⬇️
src/mod_muc_room.erl 77.56% <100.00%> (-0.04%) ⬇️
src/mam/mod_mam.erl 88.31% <0.00%> (-0.94%) ⬇️
src/muc_light/mod_muc_light.erl 82.96% <0.00%> (-0.88%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 76.83% <0.00%> (-0.57%) ⬇️
src/mod_roster.erl 77.26% <0.00%> (-0.47%) ⬇️
src/mod_muc_log.erl 77.72% <0.00%> (ø)
src/pubsub/mod_pubsub.erl 72.00% <0.00%> (+0.05%) ⬆️
src/ejabberd_sm.erl 76.68% <0.00%> (+0.30%) ⬆️
src/mam/mod_mam_utils.erl 89.64% <0.00%> (+0.64%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7935ad...6c37f73. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chrzaszcz chrzaszcz merged commit b268fa8 into master Feb 8, 2021
@chrzaszcz chrzaszcz deleted the uri_in_http branch February 8, 2021 07:46
@leszke leszke added this to the 4.2.0 milestone Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants