Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepared queries for mod_offline - rebased #3040

Merged
merged 5 commits into from
Mar 1, 2021

Conversation

arcusfelis
Copy link
Contributor

This PR addresses #

Proposed changes include:

  • describe the functionality changes
  • describe new or updated tests
  • describe changes to the documentation

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #3040 (64f4d65) into mu-prepared-queries3 (c3ff8c8) will increase coverage by 0.02%.
The diff coverage is 96.66%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           mu-prepared-queries3    #3040      +/-   ##
========================================================
+ Coverage                 78.48%   78.50%   +0.02%     
========================================================
  Files                       378      378              
  Lines                     31130    31109      -21     
========================================================
- Hits                      24431    24423       -8     
+ Misses                     6699     6686      -13     
Impacted Files Coverage Δ
src/rdbms/rdbms_queries_mssql.erl 100.00% <ø> (+33.33%) ⬆️
src/offline/mod_offline_rdbms.erl 93.84% <96.55%> (+10.02%) ⬆️
src/rdbms/rdbms_queries.erl 79.62% <100.00%> (-2.63%) ⬇️
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 86.60% <0.00%> (-1.79%) ⬇️
src/cassandra/mongoose_cassandra_worker.erl 72.64% <0.00%> (-0.48%) ⬇️
src/pubsub/mod_pubsub_db_mnesia.erl 92.40% <0.00%> (-0.43%) ⬇️
src/rdbms/mongoose_rdbms.erl 64.58% <0.00%> (-0.42%) ⬇️
src/mod_muc_log.erl 77.72% <0.00%> (ø)
src/mod_muc_room.erl 77.50% <0.00%> (+0.11%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ff8c8...64f4d65. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a few comments from me.

src/offline/mod_offline_rdbms.erl Outdated Show resolved Hide resolved
src/offline/mod_offline_rdbms.erl Outdated Show resolved Hide resolved
src/offline/mod_offline_rdbms.erl Outdated Show resolved Hide resolved
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@chrzaszcz chrzaszcz merged commit f97b9f0 into mu-prepared-queries3 Mar 1, 2021
@chrzaszcz chrzaszcz deleted the mu-prepared-queries-offline-3 branch March 1, 2021 13:09
arcusfelis added a commit that referenced this pull request Mar 1, 2021
arcusfelis added a commit that referenced this pull request Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants