Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General docs improvements #3046

Merged
merged 1 commit into from
Mar 2, 2021
Merged

General docs improvements #3046

merged 1 commit into from
Mar 2, 2021

Conversation

NelsonVides
Copy link
Collaborator

version css and js is not necessary as materials now accepts mike as a provider and automatically fills that for us more beautifully (but I honestly have no way to test this without

The site_url was missing the latest/ suffix and hence the sitemap wasn't exactly accurate.

And some metadata is now added, for more html tagging with references to us.

You can have a look in my fork about how would it look: https://nelsonvides.github.io/MongooseIM/latest/, and also check the sitemap generated: https://nelsonvides.github.io/MongooseIM/latest/sitemap.xml

version css and js is not necessary as materials now accepts mike as a
provider and automatically fills that for us more beautifully.

The site_url was missing the `latest/` suffix and hence the sitemap
wasn't up-to-date.

And some metadata is now added, for more html tagging.
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #3046 (5dee72a) into master (2f51f6d) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3046      +/-   ##
==========================================
+ Coverage   78.02%   78.05%   +0.02%     
==========================================
  Files         374      374              
  Lines       31190    31190              
==========================================
+ Hits        24337    24344       +7     
+ Misses       6853     6846       -7     
Impacted Files Coverage Δ
src/pubsub/mod_pubsub_db_mnesia.erl 92.40% <0.00%> (-0.43%) ⬇️
src/ejabberd_sm.erl 75.76% <0.00%> (-0.31%) ⬇️
src/mod_muc_room.erl 77.50% <0.00%> (+0.17%) ⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 73.58% <0.00%> (+1.88%) ⬆️
src/cassandra/mongoose_cassandra_worker.erl 73.11% <0.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f51f6d...5dee72a. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@chrzaszcz chrzaszcz merged commit eb561a9 into master Mar 2, 2021
@chrzaszcz chrzaszcz deleted the docs_improvements branch March 2, 2021 08:16
@leszke leszke added this to the 4.2.0 milestone Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants