[OS] fix type declaration

[NelsonVides]

In case I’m mixing up some type, I’m sharing this error dialyzer should have complained about:

MongooseIM/src/muc_light/mod_muc_light_codec.erl

Line 32 in 3ce2355

-callback encode(Request :: muc_light_encode_request(), OriginalSender :: jid:jid(),

says that encode’s first parameter is a muc_light_encode_request()

MongooseIM/src/muc_light/mod_muc_light_codec_modern.erl

Line 50 in 3ce2355

encode({#msg{} = Msg, AffUsers}, Sender, {RoomU, RoomS} = RoomUS, HandleFun) ->

the first head of encode in the actual implementation takes a {msg(), aff_users()}

MongooseIM/include/mod_muc_light.hrl

Lines 115 to 122 in 3ce2355

	-type muc_light_encode_request() :: {get, #config{} | #affiliations{} | #info{} | #blocking{}}
	| {set, #affiliations{}, OldAffUsers :: aff_users(),
	NewAffUsers :: aff_users()}
	| {set, #blocking{}}
	| {set, #create{}, UniqueRequested :: boolean()}
	| {set, #destroy{}, AffUsers :: aff_users()}
	| {set, #config{}, AffUsers :: aff_users()}
	| {error, bad_request}.

does not define {msg(), aff_users()} as any of the possibilities for this type

This arose when writing a custom codec for a client that would modify a couple of requests but just forward everything else to the modern codec, only when calling encode directly with an actual value, dialyzer complained.

[codecov]

Codecov Report

Merging #3057 (38b0c9a) into master (135fec2) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3057      +/-   ##
==========================================
- Coverage   78.53%   78.50%   -0.04%     
==========================================
  Files         378      378              
  Lines       31119    31119              
==========================================
- Hits        24440    24429      -11     
- Misses       6679     6690      +11     

Impacted Files	Coverage Δ
src/elasticsearch/mongoose_elasticsearch.erl	76.92% <0.00%> (-7.70%)	⬇️
src/mongoose_tcp_listener.erl	76.59% <0.00%> (-4.26%)	⬇️
src/mam/mod_mam_elasticsearch_arch.erl	86.60% <0.00%> (-1.79%)	⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl	76.83% <0.00%> (-0.57%)	⬇️
src/ejabberd_s2s_out.erl	57.89% <0.00%> (-0.46%)	⬇️
src/pubsub/mod_pubsub_db_mnesia.erl	92.40% <0.00%> (-0.43%)	⬇️
src/ejabberd_c2s.erl	89.25% <0.00%> (-0.23%)	⬇️
src/mod_muc_room.erl	77.50% <0.00%> (-0.06%)	⬇️
src/mod_muc_log.erl	77.72% <0.00%> (ø)
src/ejabberd_sm.erl	76.21% <0.00%> (+0.30%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135fec2...38b0c9a. Read the comment docs.

[DenysGonchar]

👍