Improve pipeline for mod_smart_markers #3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3068 +/- ##
==========================================
- Coverage 78.76% 78.69% -0.08%
==========================================
Files 378 378
Lines 31102 31110 +8
==========================================
- Hits 24499 24482 -17
- Misses 6603 6628 +25
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module was doing one non-optimal check, that is, it was checking if the user has rights to access a room using the
can_access_roomhook, before checking that the message being processed actually has any marker to begin with. This is non-optimal, ascan_access_roomrequires another hook call and a DB query to verify affiliations, and will usually return true unless misbehaving clients, while checking whether a message has actually any marker is an in-place check with higher chances to return false.