Prepared queries pubsub #3074
Merged
Prepared queries pubsub #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for mssql and mysql
prepared queries pubsub
- Unchanged behaviour without item ids
- Slight changes if item ids are provided:
- Results are fetched one by one - should be fast enough
as there shouldn't be too many IDs and there is a way to limit this.
- Results have the same order as item ids - this is more intuitive
for the end user, XEP-0060 does not specify this
- max_items with item ids is a combination not mentioned in the XEP,
but still supported for completeness.
- Separate INSERT and SELECT to work on all DBs
- SELECT the entire row as this query is already prepared
and is not much more costly
- Insert parents one by one
- Always delete old parents on update to prevent the corner case
when all aprents are deleted.
Traverse nodes one by one - it might be slower, but complex collection structures shouldn't be used frequently.
Prepared queries for PubSub - part 2
Codecov Report
@@ Coverage Diff @@
## master #3074 +/- ##
==========================================
- Coverage 78.76% 78.70% -0.07%
==========================================
Files 378 377 -1
Lines 31102 31083 -19
==========================================
- Hits 24499 24465 -34
- Misses 6603 6618 +15
Continue to review full report at Codecov.
|
chrzaszcz
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My and @chrzaszcz collective effort of preparing SQL queries in
pubsubmodules.