Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set archive_groupchats to false by default #3082

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

arcusfelis
Copy link
Contributor

Proposed changes include:

  • Set archive_groupchats to false by default

modules.mod_mam_meta.pm.archive_groupchats

  • Syntax: boolean
  • Default: false (yes, now)
  • Example: modules.mod_mam_meta.pm.archive_groupchats = true

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #3082 (be8eade) into master (f166757) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3082      +/-   ##
==========================================
- Coverage   78.84%   78.83%   -0.01%     
==========================================
  Files         380      380              
  Lines       31227    31227              
==========================================
- Hits        24620    24619       -1     
- Misses       6607     6608       +1     
Impacted Files Coverage Δ
src/mam/mod_mam.erl 89.25% <100.00%> (ø)
...c/global_distrib/mod_global_distrib_server_mgr.erl 75.14% <0.00%> (-2.26%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.69% <0.00%> (-1.89%) ⬇️
src/mod_muc_room.erl 77.50% <0.00%> (-0.06%) ⬇️
src/mod_muc_log.erl 77.72% <0.00%> (ø)
src/pubsub/mod_pubsub_db_mnesia.erl 92.82% <0.00%> (+0.42%) ⬆️
src/ejabberd_sm.erl 76.52% <0.00%> (+0.60%) ⬆️
src/ejabberd.erl 55.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f166757...be8eade. Read the comment docs.

Copy link
Collaborator

@DenysGonchar DenysGonchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@DenysGonchar DenysGonchar merged commit 91859d7 into master Apr 14, 2021
@DenysGonchar DenysGonchar deleted the mu-dont-archive-groupchats-by-default branch April 14, 2021 22:54
@leszke leszke added this to the 4.2.0 milestone Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants