Prepare queries in mongoose_cluster_id #3098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3098 +/- ##
=======================================
Coverage 79.02% 79.02%
=======================================
Files 386 386
Lines 31830 31832 +2
=======================================
+ Hits 25153 25155 +2
Misses 6677 6677
Continue to review full report at Codecov.
|
leszke
force-pushed
the
prepared-queries-mongoose-cluster-id
branch
from
186a80d
to
ad04bc7
Compare
chrzaszcz
reviewed
Apr 26, 2021
chrzaszcz
reviewed
Apr 26, 2021
src/mongoose_cluster_id.erl
Outdated
|
|
||
| -spec execute_cluster_insert_new(binary()) -> mongoose_rdbms:query_result(). | ||
| execute_cluster_insert_new(ID) -> | ||
| mongoose_rdbms:execute(global, cluster_insert_new, [ID]). |
There was a problem hiding this comment.
Please just use execute_successfully in both queries for consistency.
leszke
force-pushed
the
prepared-queries-mongoose-cluster-id
branch
3 times, most recently
from
5bb0113
to
ef7ff4d
Compare
leszke
force-pushed
the
prepared-queries-mongoose-cluster-id
branch
from
ef7ff4d
to
3f4b722
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.