Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi tenancy tests #3108

Merged
merged 7 commits into from
May 4, 2021
Merged

Multi tenancy tests #3108

merged 7 commits into from
May 4, 2021

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Apr 30, 2021

Initial test configuration for dynamic domains. The plan is to extend them in subsequent PR's.
See individual commits for more details.

- Common test allows this and looks up the option
    in subsequent files until it is found.
- This will be used in tests for dynamic domains

Also:
  - Do not read the properties multiple times in a row
  - Do not assume that 'mim' and 'reg' clusters are always present
    (reg will be disabled for multi-tenancy tests)
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #3108 (5a10883) into master (48039c1) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3108      +/-   ##
==========================================
+ Coverage   79.15%   79.17%   +0.02%     
==========================================
  Files         387      387              
  Lines       31832    31832              
==========================================
+ Hits        25196    25204       +8     
+ Misses       6636     6628       -8     
Impacted Files Coverage Δ
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 86.60% <0.00%> (-1.79%) ⬇️
src/ejabberd_c2s.erl 89.20% <0.00%> (-0.15%) ⬇️
src/mod_muc_log.erl 77.72% <0.00%> (ø)
src/ejabberd_sm.erl 83.05% <0.00%> (+0.33%) ⬆️
src/wpool/mongoose_wpool.erl 85.00% <0.00%> (+1.00%) ⬆️
src/ejabberd_local.erl 71.22% <0.00%> (+2.87%) ⬆️
src/auth/ejabberd_auth_dummy.erl 58.33% <0.00%> (+20.83%) ⬆️
src/mongoose_router_dynamic_domains.erl 100.00% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48039c1...5a10883. Read the comment docs.

This is done in ct_mongoose_hook to be automatic
  and not require changing all test suites.
Run one suite for now, this will be extended in subsequent commits.
@chrzaszcz chrzaszcz requested a review from arcusfelis May 4, 2021 11:31
Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@arcusfelis arcusfelis merged commit 3d3ff8d into master May 4, 2021
@arcusfelis arcusfelis deleted the multi-tenancy-tests branch May 4, 2021 11:43
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants