Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room EventData is map now #3111

Merged
merged 6 commits into from
May 11, 2021
Merged

Room EventData is map now #3111

merged 6 commits into from
May 11, 2021

Conversation

arcusfelis
Copy link
Contributor

This PR addresses "some tech debt".

Proposed changes include:

  • room_event_data is now map (was a proplist)
  • Remove room_send_packet hook

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #3111 (da1db71) into master (9557370) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3111      +/-   ##
==========================================
- Coverage   79.22%   79.19%   -0.03%     
==========================================
  Files         388      388              
  Lines       31858    31846      -12     
==========================================
- Hits        25238    25220      -18     
- Misses       6620     6626       +6     
Impacted Files Coverage Δ
src/mod_muc.erl 76.90% <ø> (ø)
src/mongoose_hooks.erl 92.90% <ø> (-0.05%) ⬇️
src/mam/mod_mam_muc.erl 73.01% <100.00%> (-0.70%) ⬇️
src/mod_muc_room.erl 77.51% <100.00%> (-0.02%) ⬇️
src/muc_light/mod_muc_light_codec_legacy.erl 91.05% <100.00%> (-0.05%) ⬇️
src/muc_light/mod_muc_light_codec_modern.erl 89.38% <100.00%> (-0.24%) ⬇️
src/ejabberd.erl 45.00% <0.00%> (-10.00%) ⬇️
..._distrib/mod_global_distrib_outgoing_conns_sup.erl 80.00% <0.00%> (-8.00%) ⬇️
src/mam/mod_mam.erl 88.03% <0.00%> (-0.96%) ⬇️
src/muc_light/mod_muc_light.erl 83.69% <0.00%> (-0.86%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9557370...da1db71. Read the comment docs.

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally love this change, thanks for the quick action! Just a few minor comments 🙂

CHANGELOG.md Outdated
Comment on lines 1 to 5
- Use a map instead of a proplist in the `room_event_data` hook
for the event data information.
- `room_send_packet` hook removed.
Use `filter_room_packet` instead.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the place to put these things, they should go to the proper migration file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just making less work for people, who need to write a changelog for the next release.

src/muc_light/mod_muc_light_codec_legacy.erl Outdated Show resolved Hide resolved
src/muc_light/mod_muc_light_codec_modern.erl Outdated Show resolved Hide resolved
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome to me 🎉

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, forgot, the changelog, I didn't mean to remove it, I meant to put it on a new migration file, in the doc/migrations/ dir, as we always do

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@NelsonVides NelsonVides merged commit 2bc323d into master May 11, 2021
@NelsonVides NelsonVides deleted the mu-send-data-is-map branch May 11, 2021 07:32
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants