Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding multitenancy support for mod_carboncopy #3130

Merged
merged 3 commits into from
May 26, 2021

Conversation

DenysGonchar
Copy link
Collaborator

@DenysGonchar DenysGonchar commented May 26, 2021

This PR introduces dynamic domains support for mod_carboncopy.
Service discovery doesn't work for dynamic domains (as mod_disco doesn't support it yet), but still works correctly for statically configured domains

for a local testing you can use this command:

test-runner.sh --skip-small-tests --skip-cover --spec dynamic_domains.spec --preset pgsql_mnesia -- carboncopy
test-runner.sh --skip-small-tests --skip-cover --preset pgsql_mnesia -- carboncopy

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #3130 (ab2a243) into master (45a47ec) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3130      +/-   ##
==========================================
+ Coverage   79.44%   79.47%   +0.03%     
==========================================
  Files         395      395              
  Lines       32167    32168       +1     
==========================================
+ Hits        25555    25567      +12     
+ Misses       6612     6601      -11     
Impacted Files Coverage Δ
src/ejabberd_app.erl 93.75% <ø> (ø)
src/mod_carboncopy.erl 88.81% <100.00%> (+0.07%) ⬆️
src/ejabberd_c2s.erl 89.35% <0.00%> (+0.22%) ⬆️
src/mod_roster.erl 76.85% <0.00%> (+0.23%) ⬆️
src/ejabberd_sm.erl 84.51% <0.00%> (+0.67%) ⬆️
src/mod_bosh_socket.erl 78.88% <0.00%> (+1.24%) ⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 73.58% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a47ec...ab2a243. Read the comment docs.

this commit can be tested using the following command:
   test-runner.sh --skip-small-tests --skip-cover --spec dynamic_domains.spec --preset pgsql_mnesia -- carboncopy
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, and very good insight on how to carry the work for the multitenancy migration, thanks!

Comment on lines +15 to +16
{skip_cases, "tests", carboncopy_SUITE, [discovering_support],
"at the moment mod_disco doesn't support dynamic domains"}.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks for the idea!

@NelsonVides NelsonVides merged commit 5166ab3 into master May 26, 2021
@NelsonVides NelsonVides deleted the updating-mod_carboncopy-module branch May 26, 2021 17:28
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants