-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding multitenancy support for mod_carboncopy #3130
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3130 +/- ##
==========================================
+ Coverage 79.44% 79.47% +0.03%
==========================================
Files 395 395
Lines 32167 32168 +1
==========================================
+ Hits 25555 25567 +12
+ Misses 6612 6601 -11
Continue to review full report at Codecov.
|
this commit can be tested using the following command: test-runner.sh --skip-small-tests --skip-cover --spec dynamic_domains.spec --preset pgsql_mnesia -- carboncopy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, and very good insight on how to carry the work for the multitenancy migration, thanks!
{skip_cases, "tests", carboncopy_SUITE, [discovering_support], | ||
"at the moment mod_disco doesn't support dynamic domains"}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant, thanks for the idea!
This PR introduces dynamic domains support for mod_carboncopy.
Service discovery doesn't work for dynamic domains (as mod_disco doesn't support it yet), but still works correctly for statically configured domains
for a local testing you can use this command: