Remove check_carboncopy CT hook #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hook is a leftover from when mod_carboncopy was using its own mnesia table. See commit e0b1d9d when it was removed for details. It is safe to remove this hook, as other hooks like `check_sessions` or `check_registered_users` together with using escalus fresh stories should already ensure that no user configuration leaks between the test groups.
Codecov Report
@@ Coverage Diff @@
## master #3134 +/- ##
==========================================
+ Coverage 79.46% 79.47% +0.01%
==========================================
Files 395 395
Lines 32172 32172
==========================================
+ Hits 25565 25569 +4
+ Misses 6607 6603 -4
Continue to review full report at Codecov.
|
NelsonVides
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
Suite ... finished dirty.messages appearing when running the tests. They appeared because of a failing common test hook.This hook is a leftover from when
mod_carboncopywas using its own mnesia table. See commit e0b1d9d in which it was removed for details. It is safe to remove this hook, as other hooks likecheck_sessionsorcheck_registered_userstogether with using escalus fresh stories should already ensure that no user configuration leaks between the test groups.